[CINN]delete redundant SetShapeOrDataForValue #64470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
May 21, 2024
| } | ||
|
|
||
| if (VLOG_IS_ON(4)) { | ||
| ::std::cerr << ">>>>>>>>>>>>>>>>>>>> cinn_op.fusion(op_id: op_" |
There was a problem hiding this comment.
这个不像是error信息，对调试如果没有作用的话就去掉吧
paddle/cinn/common/broadcast_tree.cc
Outdated
| return Pattern2Placement{{rhs, lhs}}; | ||
| } | ||
| if (lhs.isa<std::string>()) { | ||
| if (GetSymbolSet(rhs).count(ToString(lhs)) != 0) { |
There was a problem hiding this comment.
这样对于 S0*S1*S2 <----> S0*S2 的情况是不是处理不了？
There was a problem hiding this comment.
这里我们只用保证uniform的符号不被替换就可以了
zyfncg
reviewed
May 22, 2024
paddle/cinn/common/broadcast_tree.cc
Outdated
| @@ -120,6 +120,12 @@ using Pattern2Placement = std::unordered_map<symbol::DimExpr, symbol::DimExpr>; | |||
| Pattern2Placement ConstructCstrLhsEqRhsReplacement( | |||
| const symbol::Broadcastable<symbol::DimExpr>& broadcastable_condition) { | |||
| auto [lhs, rhs] = *broadcastable_condition; | |||
| if (SubstituteDimExpr(rhs, Pattern2Placement{{rhs, lhs}}) != rhs) { | |||
There was a problem hiding this comment.
rhs != lhs的情况下，这个条件分支一定是true吧？
There was a problem hiding this comment.
已修复，上一个commit里发生了粘贴错误
zyfncg
approved these changes
May 23, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 23, 2024
* [CINN]delete redundant SetShapeOrDataForValue * update broadcast_tree Substitute policy * fix * fix
chen2016013
pushed a commit
to chen2016013/Paddle
that referenced
this pull request
May 26, 2024
* [CINN]delete redundant SetShapeOrDataForValue * update broadcast_tree Substitute policy * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
Pcard-67164
This PR delete redundant SetShapeOrDataForValue.