Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Scalar] Replace add_ad_func, subtract_ad_func with scale_ad_func when meeting scalar op Tensor" #63012

Conversation

HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Mar 25, 2024

Important

PR #62598 might cause error in NPU device as bias argument of scale kernel is not adapted to Scalar type.

Reverts #62598

Related fix PR

Copy link

paddle-bot bot commented Mar 25, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

paddle-bot bot commented Mar 25, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@HydrogenSulfate
Copy link
Contributor Author

Closed for fix PR: PaddlePaddle/PaddleCustomDevice#1073 is merged.

@HydrogenSulfate HydrogenSulfate deleted the revert-62598-scale_use_scalar_bias branch September 13, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant