Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dy2St] Enable legacy IR dy2st test #59312

Merged
merged 16 commits into from
Nov 27, 2023
Merged

[Dy2St] Enable legacy IR dy2st test #59312

merged 16 commits into from
Nov 27, 2023

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 23, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

启用因为 #59152 PT 切默认导致默认关闭的老 IR 单测，顺便移除了 utils 后的 _new 后缀，并将装饰器名进行了统一规范

  • test_pir_only → test_pt_only
  • test_pir_api_only → test_pir_only
  • test_legacy_and_pir → test_legacy_and_pt
  • test_legacy_and_pir_api → test_legacy_and_pir
  • test_legacy_and_pir_exe_and_pir_api → test_legacy_and_pt_and_pir

增加 test_default_mode_only 装饰在长时间的单测上，以避免 CI 时间过长的问题，该问题将在 #59339 着手解决

并支持了文件级别某一种模式的禁用

PCard-66972

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 23, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ooooo-create ooooo-create mentioned this pull request Nov 24, 2023
Closed
@gouzil gouzil self-requested a review November 27, 2023 02:38
XieYunshen
XieYunshen previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gouzil
gouzil previously approved these changes Nov 27, 2023
View reviewed changes
XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kangguangli
kangguangli previously approved these changes Nov 27, 2023
View reviewed changes
XieYunshen
XieYunshen approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gouzil
gouzil approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@gouzil gouzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo mentioned this pull request Nov 27, 2023
Merged
XiaoguangHu01
XiaoguangHu01 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit b6b61c5 into PaddlePaddle:develop Nov 27, 2023
27 of 28 checks passed
@SigureMo SigureMo deleted the dy2st/enable-legacy-ir-tests branch November 27, 2023 10:27
@ooooo-create ooooo-create mentioned this pull request Nov 28, 2023
Merged
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@SigureMo @SecretXV
[Dy2St] Enable legacy IR dy2st test (PaddlePaddle#59312)
7865558
@ooooo-create ooooo-create mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouzil gouzil gouzil approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@kangguangli kangguangli kangguangli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SigureMo @kangguangli @XieYunshen @XiaoguangHu01 @gouzil