Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API and unit test for reshape #37232

Merged
merged 9 commits into from
Nov 16, 2021

Conversation

YuanRisheng
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Add user API and unit test for reshape and change vector to vector<int64_t> for shape

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +1887 to +1889
std::type_index(typeid(std::vector<int64_t>)) &&
std::type_index(attr.type()) ==
std::type_index(typeid(std::vector<int>))) {
Copy link
Contributor

@zyfncg zyfncg Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【TODO】vector<int64>参数类型可同时支持vector<int>vector<int64>的参数

@chenwhql chenwhql merged commit 79b49c2 into PaddlePaddle:develop Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants