Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should this line return a string? #7627

Closed
putcn opened this issue Jan 18, 2018 · 6 comments
Closed

should this line return a string? #7627

putcn opened this issue Jan 18, 2018 · 6 comments
Assignees

Comments

@putcn
Copy link
Contributor

putcn commented Jan 18, 2018

I just found following line is blocking my build, since it's supposed to return a string.

virtual std::string GetReqName() { assert(false); }

https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/detail/grpc_server.cc#L39

@helinwang
Copy link
Contributor

Yes, thanks! This PR fixes it: #7626

I think we should turn on distributed flag on TeamCity, is there any concern (such as longer build speed) for turning it on?

@putcn
Copy link
Contributor Author

putcn commented Jan 18, 2018

I don't see why we shouldn't.

@Yancey1989
Copy link
Contributor

Yes, it tasks longer time with DWITH_DISTRIBUTE=ON, I add a scheduled job on CI https://paddleci.ngrok.io/viewType.html?buildTypeId=Paddle_DistributedUnitTestNightly , maybe we can concern this job.

@putcn
Copy link
Contributor Author

putcn commented Jan 18, 2018

I see this job is triggered by schedule, should we make it triggered by change so that build can be verified before it's merged to main branch?
I think it would be more reasonable to add DWITH_DISTRIBUTE=ON to PR_CI, since that's kinda gateway for repo code quality.

@typhoonzero
Copy link
Contributor

This #7605 also fix this.

@typhoonzero
Copy link
Contributor

@putcn @Yancey1989 I think we can turn it on once we have the CI machines upgraded to have more computing power.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants