-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should this line return a string? #7627
Comments
Yes, thanks! This PR fixes it: #7626 I think we should turn on distributed flag on TeamCity, is there any concern (such as longer build speed) for turning it on? |
I don't see why we shouldn't. |
Yes, it tasks longer time with |
I see this job is triggered by schedule, should we make it triggered by change so that build can be verified before it's merged to main branch? |
This #7605 also fix this. |
@putcn @Yancey1989 I think we can turn it on once we have the CI machines upgraded to have more computing power. |
I just found following line is blocking my build, since it's supposed to return a string.
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/detail/grpc_server.cc#L39
The text was updated successfully, but these errors were encountered: