-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we add device field in our framwork.proto #6035
Comments
I agree, it's a very useful feature. Maybe we can work out a first version that the user can not do manual placement, but later add this feature? |
@QiJune Quick question: since all operators know where to run, do we still need the |
I think that we will have a pool of DeviceContext. What Executor do is to take a DeviceContext from the pool to run the operator under the guide of device in operator. |
Our neural network topology will be serialized to
ProgramDesc
. And we hope that thisProgramDesc
can be transpose to different hardware environments, such as single CPU/GPU, multi-GPUs, or multi-nodes.However, we should also expose device configuration to users. Following is an example:
I think that this feature is important, we should provides such interface for users to set device for specific layers.
Then, there comes a question, where to store these device information. At now, there is no device field in framework.proto.
In tensorflow, there is a device field in node_def.proto. In Mxnet, there is a device attribute of graph to store users's device configuration.
If we want to support such feature(user can set device for specific operator), we have to handle these device configuration.
Maybe we should add a device field in framework.proto, or we create another struct to store the device configuration.
The text was updated successfully, but these errors were encountered: