-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operators needed by recommender system #4780
Comments
I was looking a little at what is needed to finish sequence conv pool. Option 1The current implementation seems to be a composite layer consisting of context projection + fully connected + sequence pool: It looks like we already have C++ ops for fully connected and sequence pool, so only context projection seems to be missing for this route. Option 2context projection + fully connected is a special case of sequence convolution, as the name "sequence conv pool" already implies. If we go this route, it would make more sense to prioritize implementing a sequence conv op than a context projection op. Questions
|
I'm developing context_project_op code, and it's probably going to be done this week. |
@mkliegl @chengduoZH discussed with me a few days ago. Now I prefer to the second option. |
I'm developing sequence pool code, and it's probably going to be done this week.
|
sequence conv has been merged. @QiJune |
The text was updated successfully, but these errors were encountered: