Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators needed by recommender system #4780

Closed
6 tasks done
QiJune opened this issue Oct 13, 2017 · 5 comments
Closed
6 tasks done

operators needed by recommender system #4780

QiJune opened this issue Oct 13, 2017 · 5 comments
Assignees
Labels

Comments

@QiJune
Copy link
Member

QiJune commented Oct 13, 2017

  • fully connected
  • lookup table, sparse gradient
  • sequence conv pool
  • cos sim
  • sparse optimizers, adam
  • square error cost
@mkliegl
Copy link
Contributor

mkliegl commented Oct 18, 2017

I was looking a little at what is needed to finish sequence conv pool.

Option 1

The current implementation seems to be a composite layer consisting of context projection + fully connected + sequence pool:

https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/trainer_config_helpers/networks.py#L40

It looks like we already have C++ ops for fully connected and sequence pool, so only context projection seems to be missing for this route.

Option 2

context projection + fully connected is a special case of sequence convolution, as the name "sequence conv pool" already implies.

If we go this route, it would make more sense to prioritize implementing a sequence conv op than a context projection op.

Questions

  • Do others have a preference between Options 1 and 2?
  • Is somebody else already working on any of sequence pool / sequence conv / context projection / sequence conv pool layer?

@chengduoZH
Copy link
Contributor

I'm developing context_project_op code, and it's probably going to be done this week.

@qingqing01
Copy link
Contributor

@mkliegl @chengduoZH discussed with me a few days ago. Now I prefer to the second option.

@luotao1
Copy link
Contributor

luotao1 commented Oct 19, 2017

I'm developing sequence pool code, and it's probably going to be done this week.

@chengduoZH
Copy link
Contributor

sequence conv has been merged. @QiJune

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants