-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tons of warnings about using-declaration in utils/Flags.h #3277
Comments
Close this as there has been one #1117 |
Those warnings about DECLARE_string(nics);
DECLARE_string(rdma_tcp);
DECLARE_string(comment);
... The same case with those warnings about DECLARE_string(log_dir);
DECLARE_string(log_link); Right above these two lines, there is the definition of // Special case for string, because we have to specify the namespace
// std::string, which doesn't play nicely with our FLAG__namespace hackery.
#define DECLARE_string(name) \
namespace fLS { \
extern GOOGLE_GLOG_DLL_DECL std::string& FLAGS_##name; \
} \
using fLS::FLAGS_##name
#endif But don't be fooled -- above macro definition was surrounded by #define DECLARE_string(name) \
/* We always want to import declared variables, dll or no */ \
namespace fLS { \
using ::fLS::clstring; \
extern GFLAGS_DLL_DECLARE_FLAG ::fLS::clstring& FLAGS_##name; \
} \
using fLS::FLAGS_##name It looks to me that it's Above source code is the most recent version of gflags https://github.com/gflags/gflags/blob/master/src/gflags_declare.h.in#L147 downloaded by our |
The building log is full of
The text was updated successfully, but these errors were encountered: