Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix the PP-Matting bugs about the size computing and update PP-Matting single test #435

Merged
merged 111 commits into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
1684b05
first commit for yolov7
ziqi-jin Jul 13, 2022
71c00d9
pybind for yolov7
ziqi-jin Jul 14, 2022
21ab2f9
CPP README.md
ziqi-jin Jul 14, 2022
d63e862
CPP README.md
ziqi-jin Jul 14, 2022
7b3b0e2
modified yolov7.cc
ziqi-jin Jul 14, 2022
d039e80
README.md
ziqi-jin Jul 15, 2022
a34a815
python file modify
ziqi-jin Jul 18, 2022
eb010a8
merge test
ziqi-jin Jul 18, 2022
39f64f2
delete license in fastdeploy/
ziqi-jin Jul 18, 2022
d071b37
repush the conflict part
ziqi-jin Jul 18, 2022
d5026ca
README.md modified
ziqi-jin Jul 18, 2022
fb376ad
README.md modified
ziqi-jin Jul 18, 2022
4b8737c
file path modified
ziqi-jin Jul 18, 2022
ce922a0
file path modified
ziqi-jin Jul 18, 2022
6e00b82
file path modified
ziqi-jin Jul 18, 2022
8c359fb
file path modified
ziqi-jin Jul 18, 2022
906c730
file path modified
ziqi-jin Jul 18, 2022
80c1223
README modified
ziqi-jin Jul 18, 2022
6072757
README modified
ziqi-jin Jul 18, 2022
2c6e6a4
move some helpers to private
ziqi-jin Jul 18, 2022
48136f0
add examples for yolov7
ziqi-jin Jul 18, 2022
6feca92
api.md modified
ziqi-jin Jul 18, 2022
ae70d4f
api.md modified
ziqi-jin Jul 18, 2022
f591b85
api.md modified
ziqi-jin Jul 18, 2022
f0def41
YOLOv7
ziqi-jin Jul 18, 2022
15b9160
yolov7 release link
ziqi-jin Jul 18, 2022
4706e8c
yolov7 release link
ziqi-jin Jul 18, 2022
dc83584
yolov7 release link
ziqi-jin Jul 18, 2022
086debd
copyright
ziqi-jin Jul 18, 2022
4f980b9
change some helpers to private
ziqi-jin Jul 18, 2022
2e61c95
Merge branch 'develop' into develop
ziqi-jin Jul 19, 2022
80beadf
change variables to const and fix documents.
ziqi-jin Jul 19, 2022
8103772
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 19, 2022
f5f7a86
gitignore
ziqi-jin Jul 19, 2022
e6cec25
Transfer some funtions to private member of class
ziqi-jin Jul 19, 2022
e25e4f2
Transfer some funtions to private member of class
ziqi-jin Jul 19, 2022
e8a8439
Merge from develop (#9)
ziqi-jin Jul 20, 2022
a182893
first commit for yolor
ziqi-jin Jul 20, 2022
3aa015f
for merge
ziqi-jin Jul 20, 2022
d6b98aa
Develop (#11)
ziqi-jin Jul 20, 2022
871cfc6
Merge branch 'yolor' into develop
ziqi-jin Jul 20, 2022
013921a
Yolor (#16)
ziqi-jin Jul 21, 2022
7a5a6d9
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 21, 2022
c996117
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 22, 2022
0aefe32
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 26, 2022
2330414
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 26, 2022
4660161
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 27, 2022
033c18e
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 28, 2022
6c94d65
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 28, 2022
85fb256
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Jul 29, 2022
90ca4cb
add is_dynamic for YOLO series (#22)
ziqi-jin Jul 29, 2022
f6a4ed2
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 1, 2022
3682091
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 3, 2022
ca1e110
Merge remote-tracking branch 'upstream/develop' into develop
ziqi-jin Aug 8, 2022
93ba6a6
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 9, 2022
767842e
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 10, 2022
cc32733
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 10, 2022
2771a3b
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 11, 2022
a1e29ac
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 11, 2022
5ecc6fe
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 11, 2022
2780588
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 12, 2022
c00be81
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 15, 2022
9082178
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 15, 2022
4b14f56
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 15, 2022
4876b82
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 16, 2022
9cebb1f
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 18, 2022
d1e3b29
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 19, 2022
69cf0d2
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 22, 2022
2ff10e1
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 23, 2022
a673a2c
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 25, 2022
832d777
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 25, 2022
e513eac
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Aug 29, 2022
ded2054
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 1, 2022
19db925
modify ppmatting backend and docs
ziqi-jin Sep 1, 2022
15be4a6
modify ppmatting docs
ziqi-jin Sep 1, 2022
3a5b93a
fix the PPMatting size problem
ziqi-jin Sep 3, 2022
f765853
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 3, 2022
c2332b0
fix LimitShort's log
ziqi-jin Sep 3, 2022
950f948
retrigger ci
ziqi-jin Sep 4, 2022
64a13c9
modify PPMatting docs
ziqi-jin Sep 4, 2022
09c073d
modify the way for dealing with LimitShort
ziqi-jin Sep 6, 2022
99969b6
Merge branch 'develop' into develop
jiangjiajun Sep 6, 2022
cf248de
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 8, 2022
9d4a4c9
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 13, 2022
622fbf7
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 15, 2022
d1cf1ad
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 19, 2022
ff9a07e
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 21, 2022
2707b03
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Sep 22, 2022
896d1d9
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 8, 2022
25ee7e2
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 12, 2022
79068d3
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 17, 2022
74b3ee0
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 21, 2022
a75c0c4
add python comments for external models
ziqi-jin Oct 21, 2022
985d273
modify resnet c++ comments
ziqi-jin Oct 21, 2022
e32a25c
modify C++ comments for external models
ziqi-jin Oct 21, 2022
8a73af6
modify python comments and add result class comments
ziqi-jin Oct 21, 2022
2aa7939
Merge branch 'develop' into doc_python
jiangjiajun Oct 22, 2022
887c53a
Merge branch 'develop' into doc_python
jiangjiajun Oct 23, 2022
963b9b9
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 24, 2022
337e8c0
fix comments compile error
ziqi-jin Oct 24, 2022
d1d6890
modify result.h comments
ziqi-jin Oct 24, 2022
67234dd
Merge branch 'develop' into doc_python
jiangjiajun Oct 24, 2022
440e2a9
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 24, 2022
ac35141
Merge branch 'doc_python' into develop
ziqi-jin Oct 24, 2022
3d83785
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 24, 2022
1c63c0a
fix ppmatting bugs
ziqi-jin Oct 24, 2022
c2cd515
modify single test code
ziqi-jin Oct 24, 2022
363a485
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 25, 2022
dc44eac
Merge branch 'PaddlePaddle:develop' into develop
ziqi-jin Oct 26, 2022
631b881
Merge pull request #39 from ziqi-jin/develop
ziqi-jin Oct 26, 2022
7d10006
merge for yolor
ziqi-jin Oct 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastdeploy/vision/common/processors/limit_long.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ bool LimitLong::ImplByOpenCV(Mat* mat) {
return true;
}

bool LimitLong::Run(Mat* mat, int max_long, int min_long, ProcLib lib) {
auto l = LimitLong(max_long, min_long);
bool LimitLong::Run(Mat* mat, int max_long, int min_long, int interp, ProcLib lib) {
auto l = LimitLong(max_long, min_long, interp);
return l(mat, lib);
}
} // namespace vision
Expand Down
2 changes: 1 addition & 1 deletion fastdeploy/vision/common/processors/limit_long.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class LimitLong : public Processor {
std::string Name() { return "LimitLong"; }

static bool Run(Mat* mat, int max_long = -1, int min_long = -1,
ProcLib lib = ProcLib::OPENCV);
int interp = 1, ProcLib lib = ProcLib::OPENCV);
int GetMaxLong() const { return max_long_; }

private:
Expand Down
4 changes: 2 additions & 2 deletions fastdeploy/vision/common/processors/limit_short.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ bool LimitShort::ImplByOpenCV(Mat* mat) {
return true;
}

bool LimitShort::Run(Mat* mat, int max_short, int min_short, ProcLib lib) {
auto l = LimitShort(max_short, min_short);
bool LimitShort::Run(Mat* mat, int max_short, int min_short, int interp, ProcLib lib) {
auto l = LimitShort(max_short, min_short, interp);
return l(mat, lib);
}
} // namespace vision
Expand Down
2 changes: 1 addition & 1 deletion fastdeploy/vision/common/processors/limit_short.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class LimitShort : public Processor {
std::string Name() { return "LimitShort"; }

static bool Run(Mat* mat, int max_short = -1, int min_short = -1,
ProcLib lib = ProcLib::OPENCV);
int interp = 1, ProcLib lib = ProcLib::OPENCV);
int GetMaxShort() const { return max_short_; }

private:
Expand Down
36 changes: 19 additions & 17 deletions fastdeploy/vision/matting/ppmatting/ppmatting.cc
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ bool PPMatting::BuildPreprocessPipelineFromConfig() {
"dimension is %zu.",
input_shape.size());

bool is_fixed_input_shape = false;
is_fixed_input_shape_ = false;
if (input_shape[2] > 0 && input_shape[3] > 0) {
is_fixed_input_shape = true;
is_fixed_input_shape_ = true;
}
if (input_shape[2] < 0 || input_shape[3] < 0) {
FDWARNING << "Detected dynamic input shape of your model, only Paddle "
Expand All @@ -88,7 +88,7 @@ bool PPMatting::BuildPreprocessPipelineFromConfig() {
if (op["type"].as<std::string>() == "LimitShort") {
int max_short = op["max_short"] ? op["max_short"].as<int>() : -1;
int min_short = op["min_short"] ? op["min_short"].as<int>() : -1;
if (is_fixed_input_shape) {
if (is_fixed_input_shape_) {
// if the input shape is fixed, will resize by scale, and the max
// shape will not exceed input_shape
long_size = max_short;
Expand All @@ -100,7 +100,7 @@ bool PPMatting::BuildPreprocessPipelineFromConfig() {
std::make_shared<LimitShort>(max_short, min_short));
}
} else if (op["type"].as<std::string>() == "ResizeToIntMult") {
if (is_fixed_input_shape) {
if (is_fixed_input_shape_) {
std::vector<int> max_size = {input_shape[2], input_shape[3]};
processors_.push_back(
std::make_shared<ResizeByShort>(long_size, 1, true, max_size));
Expand All @@ -120,7 +120,7 @@ bool PPMatting::BuildPreprocessPipelineFromConfig() {
processors_.push_back(std::make_shared<Normalize>(mean, std));
} else if (op["type"].as<std::string>() == "ResizeByShort") {
long_size = op["short_size"].as<int>();
if (is_fixed_input_shape) {
if (is_fixed_input_shape_) {
std::vector<int> max_size = {input_shape[2], input_shape[3]};
processors_.push_back(
std::make_shared<ResizeByShort>(long_size, 1, true, max_size));
Expand Down Expand Up @@ -169,24 +169,26 @@ bool PPMatting::Postprocess(
FDERROR << "Only support post process with float32 data." << std::endl;
return false;
}
std::vector<int64_t> dim{0, 2, 3, 1};
Transpose(alpha_tensor, &alpha_tensor, dim);
alpha_tensor.Squeeze(0);
Mat mat = CreateFromTensor(alpha_tensor);

auto iter_ipt = im_info.find("input_shape");
auto iter_out = im_info.find("output_shape");
if (is_fixed_input_shape_){
double scale_h = static_cast<double>(iter_out->second[0]) /
static_cast<double>(iter_ipt->second[0]);
double scale_w = static_cast<double>(iter_out->second[1]) /
static_cast<double>(iter_ipt->second[1]);
double actual_scale = std::min(scale_h, scale_w);

double scale_h = static_cast<double>(iter_out->second[0]) /
static_cast<double>(iter_ipt->second[0]);
double scale_w = static_cast<double>(iter_out->second[1]) /
static_cast<double>(iter_ipt->second[1]);
double actual_scale = std::min(scale_h, scale_w);
int size_before_pad_h = round(actual_scale * iter_ipt->second[0]);
int size_before_pad_w = round(actual_scale * iter_ipt->second[1]);

int size_before_pad_h = round(actual_scale * iter_ipt->second[0]);
int size_before_pad_w = round(actual_scale * iter_ipt->second[1]);
std::vector<int64_t> dim{0, 2, 3, 1};
Transpose(alpha_tensor, &alpha_tensor, dim);
alpha_tensor.Squeeze(0);
Mat mat = CreateFromTensor(alpha_tensor);
Crop::Run(&mat, 0, 0, size_before_pad_w, size_before_pad_h);
}

Crop::Run(&mat, 0, 0, size_before_pad_w, size_before_pad_h);
Resize::Run(&mat, iter_ipt->second[1], iter_ipt->second[0]);

result->Clear();
Expand Down
1 change: 1 addition & 0 deletions fastdeploy/vision/matting/ppmatting/ppmatting.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class FASTDEPLOY_DECL PPMatting : public FastDeployModel {

std::vector<std::shared_ptr<Processor>> processors_;
std::string config_file_;
bool is_fixed_input_shape_;
};

} // namespace matting
Expand Down
12 changes: 6 additions & 6 deletions tests/eval_example/test_ppmatting.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ def test_matting_ppmatting():
# 预测图片抠图结果
im = cv2.imread("./matting_input.jpg")
result = model.predict(im.copy())
pkl_url = ""
pkl_url = "https://bj.bcebos.com/fastdeploy/tests/ppmatting_result.pkl"
if pkl_url:
fd.download("ppmatting_result.pkl", ".")
fd.download(pkl_url, ".")
with open("./ppmatting_result.pkl", "rb") as f:
baseline = pickle.load(f)

Expand Down Expand Up @@ -66,9 +66,9 @@ def test_matting_ppmodnet():
im = cv2.imread("./matting_input.jpg")
result = model.predict(im.copy())

pkl_url = ""
pkl_url = "https://bj.bcebos.com/fastdeploy/tests/ppmodnet_result.pkl"
if pkl_url:
fd.download("ppmodnet_result.pkl", ".")
fd.download(pkl_url, ".")
with open("./ppmodnet_result.pkl", "rb") as f:
baseline = pickle.load(f)

Expand Down Expand Up @@ -96,9 +96,9 @@ def test_matting_pphumanmatting():
im = cv2.imread("./matting_input.jpg")
result = model.predict(im.copy())

pkl_url = ""
pkl_url = "https://bj.bcebos.com/fastdeploy/tests/pphumanmatting_result.pkl"
if pkl_url:
fd.download("pphumanmatting_result.pkl", ".")
fd.download(pkl_url, ".")

with open("./pphumanmatting_result.pkl", "rb") as f:
baseline = pickle.load(f)
Expand Down