Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

【PaddlePaddle Hackathon 67】Add arange op #919

Merged
merged 8 commits into from
Sep 6, 2022
Merged

【PaddlePaddle Hackathon 67】Add arange op #919

merged 8 commits into from
Sep 6, 2022

Conversation

MayYouBeProsperous
Copy link
Contributor

@MayYouBeProsperous MayYouBeProsperous mentioned this pull request Aug 31, 2022
Closed
zhhsplendid
zhhsplendid reviewed Sep 1, 2022
View reviewed changes
cinn/frontend/net_builder_test.cc Show resolved Hide resolved
cinn/hlir/op/contrib/arange.cc Show resolved Hide resolved
cinn/hlir/op/contrib/arange.cc Outdated Show resolved Hide resolved
cinn/hlir/op/contrib/arange_test.cc Show resolved Hide resolved
@zhhsplendid
Copy link
Member

PR似乎因为其他人合入，产生conflict，也pull一下develop，处理一下conflict

@MayYouBeProsperous
Copy link
Contributor Author

PR似乎因为其他人合入，产生conflict，也pull一下develop，处理一下conflict

已经修复conflict，辛苦再次review

zhhsplendid
zhhsplendid reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR做得很好，别的地方我没有意见了。把几个小评论改一下即可。

cinn/frontend/net_builder_test.cc Show resolved Hide resolved
cinn/frontend/net_builder_test.cc Outdated Show resolved Hide resolved
cinn/hlir/op/contrib/arange.cc Outdated Show resolved Hide resolved
zhhsplendid
zhhsplendid approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我没有什么问题了，LGTM，我稍后将PR合入。

@zhhsplendid zhhsplendid merged commit b823da0 into PaddlePaddle:develop Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MayYouBeProsperous @zhhsplendid