Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in sanity check for using latest provisioned models #448

Open
cameron-a-johnson opened this issue Jun 18, 2024 · 3 comments
Open

Comments

@cameron-a-johnson
Copy link
Collaborator

Here's an idea, or maybe this exists somewhere and I'm unaware:

We could add a loud warning somewhere for when the models in our model_files/ directory do not match hashes with those that we have in ansible/roles/provision-files/vars/main.yml

@Purg
Copy link
Member

Purg commented Jun 19, 2024

I just finished an experiment in this vein. This is definitely doable, but it does add a non-trival wait time to start up a container since some of our models are huge and take seconds to load in digets the checksum. Granted, I am using the python hashlib functionality to start, maybe a subprocess to use sha*sum is more appropriate/faster.

@Purg
Copy link
Member

Purg commented Jun 19, 2024

Even with things being threaded, this takes ~8 seconds to run.

@Purg
Copy link
Member

Purg commented Jun 19, 2024

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants