Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Split UBI_21 into UBI_2164 and UBI_65 [3.0]" #2471

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

MattHJensen
Copy link
Contributor

@MattHJensen MattHJensen commented Aug 21, 2020

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #2471 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2471   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          13       13           
  Lines        2582     2582           
=======================================
  Hits         2580     2580           
  Misses          2        2           
Impacted Files Coverage Δ
taxcalc/policy.py 100.00% <ø> (ø)
taxcalc/parameters.py 99.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e86cbc...b1e1a27. Read the comment docs.

@Peter-Metz
Copy link
Contributor

@MattHJensen the changes in the code base look good to me, but this is reverting some stuff we'll want to keep in the documentation (e.g. nu06 and parameter_indexing_CPI_offset)

cc @MaxGhenis

@MaxGhenis
Copy link
Contributor

@MattHJensen the changes in the code base look good to me, but this is reverting some stuff we'll want to keep in the documentation (e.g. nu06 and parameter_indexing_CPI_offset)

Should be fine, I wasn't looking to include it anyway (just did it to test and didn't revert the commit). #2450 will ensure the next release reflects the documentation changes, including running make_uguide.py which produced the field changes.

@MattHJensen MattHJensen merged commit 3b9f464 into master Aug 21, 2020
@martinholmer martinholmer deleted the revert-2463-n65 branch July 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants