-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize IRS rounding rules for indexed parameter values #2654
Comments
Hey @jdebacker , this sounds like a nice enhancement. I think you may be able to implement the new rounding rules on the By default, it rounds to 2 places. But, this method has access to the parameter's name, so you could round it however you'd like. There's a simpler example in the tests that might make it a little easier to see how the method works: https://github.com/PSLmodels/ParamTools/blob/0107eceb4a732e3c0eea32dd83b56ae253d009cb/paramtools/tests/test_parameters.py#L2229-L2283 |
Cool - thanks for the pointers @hdoupe! |
Relevant issue over in the ParamTools repo: PSLmodels/ParamTools#130 |
Note - will need to record the base year for indexing for each parameter. This can probably be recorded in the parameter metadata in @Peter-Metz do you recall doing any research on the base years for each parameter that can be used for indexing? |
Tax-Calculator should parameterize the rounding rules of indexed parameters in
policy_current_law.json
. There will probably need to be an update to the ParamTools package to handle rounding in the extrapolation of parameters.The need for rounding has been highlighted in PR #2652, where a new JSON file was created to help with the round-trip-reform test. With out that, all JSON files of past legislative reforms need to be updated to reflect rounding rules in years beyond those affected by the legislative change.
Advantages of building in rounding rules:
policy_current_law.json
-- it would no longer need to include all values from the first to last known values (currently 2013-2022), but rather just values for any legislative changescc @MattHJensen @hdoupe
The text was updated successfully, but these errors were encountered: