-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are tbi behavioral-response results for TCJA reform different from non-tbi results? #1827
Comments
Do you get the same "very odd" results using the If so, please post your If not, then this issue should be moved to the PolicyBrain repository. |
I have not replicated the results with the I opened this issue here because the TaxBrain PE page is an interface to Tax-Calculator and my intuition is that this is a problem in Tax-Calculator rather than TaxBrain. I could be wrong, but if I'm right, I thought other Tax-Calculator devs would want to know about this quickly. The results are very odd because they say that the Tax Cuts and Jobs Act raises $6 Trillion of revenue over 10 years. The JCT, for instance, scores the individual side of TCJA as losing $1.1 T over the same period. |
To provide more information regarding this PR, I created a TCJA reform that resembles the current TCJA preset on taxBrain, upon which the result here is generated, and got the following result based on the current TC master as of Jan.22, 2018: Here is its counterpart on TB: Based on the results in TC, the total combined liability over 10 years is $34,662.52 B, which yields a loss of $0.55 T over the period. It seems to me that something went wrong in TB (particularly within the dynamic provision as static results do match between TB and TC) starting 2020. Here is the reform file used:
The assumption content:
|
Thanks very much @GoFroggyRun. Sounds like this issue does belong in PolicyBrain then. Could you reopen over there? Closing here. |
@GoFroggyRun, Thanks for providing in issue #1827 TCJA reform behavioral results generated directly by Tax-Calculator. Am I reading your comment correctly when I say your analysis suggests that the odd results @MattHJensen got using TaxBrain might be a TaxBrain problem? To be sure about that, I guess you need to determine that you get the kind of results you reported above calling tbi functions rather than calling Behavior directly, which is what I imagine you did. What script did you run to get your results? |
@martinholmer thanks for your suggestion. I actually tried to generate results via tbi, it seems that, however, in order to replicate the results on TB, the base line has to be |
@GoFroggyRun
You'll need to get the policy in dictionary form from Thanks for looking into this. Please let me know if you have any problems/questions. |
@hdoupe I'm a bit confused. Could you clarify how the script you provided allows me to specify alternative baseline for behavioral assumptions? |
@GoFroggyRun is this what you have in mind?
|
@hdoupe thanks for your advice. I was having troubles with defining pre-TCJA baseline, and realized that I don't have to worry about it at all if I were working with TC ver 0.14.2. For TC release 0.14.2, which is the version that the result here is based on, the tbi interface yield exactly same results as TaxBrain. The difference table generated via tbi looks like the following:
Given my previous comment, looks like the real issue here lies within tbi, instead of PolicyBrain. In particular, tbi's result doesn't agree with tax-calculator (at least for 0.14.2). Raw results:
Code:
|
@GoFroggyRun, Thanks for your Tax-Calculator bug report. |
@GoFroggyRun said his code included this statement:
But I don't see the results of this print statement in the output you posted. |
@martinholmer Right. I only included the output for the loop part. I'm using a taxcalc package, and its version is 0.14.2, which is the version Policy Brain uses when the result here is found. |
@GoFroggyRun referred in the discussion of pull request #1840 to this issue #1827 using the phrase:
Perhaps it is a bug, I don't really know for certain. If you think there is a bug in Tax-Calculator, we have a standard procedure to deal with bugs. You should prepare a two-part pull request that does this:
We look forward to your pull request. |
I am finding these on TaxBrain.
https://www.ospc.org/dynamic/behavior_results/820/
cc @codykallen @martinholmer @hdoupe @siervicul
The text was updated successfully, but these errors were encountered: