-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section
attribute for all parameters in current_law_policy.json that can be used w puf.csv
#1141
Comments
@MattHJensen said in issue #1141 on January 12, 2016:
This is an April 14, 2016, update on the eight parameters listed above. Parameters no longer in Tax-Calculator:
Parameters documented in
Parameters documented in
Are there reasons for not including the those three AMT policy parameters and those three EducationTaxCredit parameters in the TaxBrain GUI to Tax-Calculator? |
@martinholmer, I excluded them because I couldn't remember anyone using them in the past and thought we should test a few reforms using the parameters to ensure that the results make sense. I still haven't had an opportunity to do this but continue to think it would be useful before making them available on TaxBrain. |
@MattHJensen said:
OK. That makes sense. |
@MattHJensen, Tax-Calculator issue #1141 seems to have been resolved. |
@martinholmer said:
|
Among other uses, the
section
attribute on acurrent_law_policy.json
parameter indicate to the TaxBrain team that the parameter should be available on TaxBrain and which section it should be included in.In #1109, I added
section
attributes to almost every parameter in current_law_policy.json. Given that it means more parameters will be included on TaxBrain, I also endeavored to improve their documentation so that they will make sense for TaxBrain users.The only parameters in Tax-Calculator that do not have
section
attributes now and therefore will not appear on TaxBrain are:There are four reasons why a parameter might appear on this list:
The parameter activates param_code, and the param_code parameter itself (
ALD_Investment_ec_base_code ) is stored somewhere other than
current_law_policy.json`.ALD_Investment_ec_base_code
incurrent_law_policy.json
and include documentation, then we could addALD_Investment_ec_base_code
and_ALD_Investment_ec_base_code_active
to the TaxBrain GUI input page.The parameter requires taxpayer data that isn't available in puf.csv
puf.csv_compatible
attribute tocurrent_law_policy.json
and A) don't display incompatible parameters on TaxBrain and B) disallow reform files that contain incompatible parameters on TaxBrain.The parameter is redundant, buggy, or otherwise doesn't make sense.
When I was working on Reorganize parameters -- will facilitate TaxBrain updates #1109, I thought there was a possibility that the parameter fell into category (2) or (3), and I didn't take the time to investigate whether it was appropriate to add a section label.
The text was updated successfully, but these errors were encountered: