Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd version number in Windows Dev Container #4837

Closed
richb-hanover opened this issue Aug 19, 2024 · 4 comments
Closed

Odd version number in Windows Dev Container #4837

richb-hanover opened this issue Aug 19, 2024 · 4 comments

Comments

@richb-hanover
Copy link
Contributor

What's up?

While testing various dev containers, I rebuilt PRQL on Windows. Using task web:run-playground, the playground worked as expected, except that the version number in the comment at the bottom was not 0.13.1 as expected.

Is this a concern? What other info could I provide? Thanks.

SELECT
  id
FROM
  invoices

-- Generated by PRQL compiler version:0.13.0-38-g62c7cc3c (https://prql-lang.org)
@richb-hanover
Copy link
Contributor Author

Update:

  • On my macOS Playground/Dev Container, the version string in the comment is the expected 0.13.1
  • The Windows Playground shows the commit hash for the main branch (62c7cc3) that compiled it

@kgutwin
Copy link
Collaborator

kgutwin commented Aug 19, 2024

I believe this is expected from #4804, correct?

See also #4546 which gives a little more detail.

@max-sixty
Copy link
Member

Yes this is a new feature!

@richb-hanover
Copy link
Contributor Author

Great! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants