-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XML parser doesn't support namespace declarations #307
Comments
It was a deliberate decision not to include namespaces. The objective at the time was to support the minimum viable subset as fast as possible so we could move around/past/through the ADR contribution. |
Or I could just replace the ':' with a '_' and turn the thing into a simple name? I don't really like the idea of embedding ':' in a string, 'cos it's an operator elsewhere in the grammar and there be dragons. |
Decision (DBT, ADB, GMB, MLV) to ignore |
This one is still relevant: there is perfectly valid v3 XML that still exists and is still used, as well So the Orchestrator can continue to ignore xmlns. But any example files should still contain |
The XML parser does not correctly process and ignore namespace declarations. e.g.:
where "ns0" is never used as a prefix. This pattern occasionally turns up when gluing together
xml fragments in other languages, and a compliant XML parser would be expected to just ignore
the prefix (well, unless ns0 is actually used, then it should process it).
I guess it is an artefact of rolling your own XML front-end - the IC and UoN tools never had a problem
as they all used pre-existing XML parsers. But I'm not sure why it wasn't picked up as a parsing problem
during parser development, as it appears in 100s of the v4 xml graphs included in the 2019-09-06
stress/benchmark set (though not all of them, as they come from different generators).
It can be worked around on the input side with filter programs, so it probably isn't worth the
effort of fixing this in the Orchestrator - but still an issue, albeit a low-priority one.
The text was updated successfully, but these errors were encountered: