Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dune-workspace file to dune file icons #881

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Add dune-workspace file to dune file icons #881

merged 1 commit into from
Nov 14, 2020

Conversation

zweimach
Copy link
Contributor

@zweimach zweimach commented Nov 12, 2020 •
edited
Loading

dune-workspace wasn't included in #707.

For reference: https://dune.readthedocs.io/en/stable/dune-files.html#dune-workspace.

@PKief PKief self-requested a review November 13, 2020 08:07
PKief
PKief reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! But what's about the dune-workspace.dev file? Shall we add it too?

@zweimach
Copy link
Contributor Author

Thank you! But what's about the dune-workspace.dev file? Shall we add it too?

Thanks for the reminder.

PKief
PKief approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you :)

@PKief PKief merged commit 4b7cdb9 into material-extensions:master Nov 14, 2020
@zweimach zweimach deleted the dune-workspace branch November 14, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zweimach @PKief