Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt icons #824

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Nuxt icons #824

merged 4 commits into from
Mar 15, 2021

Conversation

stefanobartoletti
Copy link
Contributor

Updated Nuxt icons to reflect the new branding of the project; more details here https://nuxtjs.org/design

@stefanobartoletti
Copy link
Contributor Author

Any news about this? Do you need something modified or fixed on these new icons? Let me know :)

@PKief PKief self-requested a review March 14, 2021 22:15
@PKief
Copy link
Member

PKief commented Mar 14, 2021

I apologize that you had to wait so long. The icons look very good. I still need a final review in the editor to check how it looks and feels and then it's very likely that it will be merged. Give me a few more days, I put it on top of my todo list for this extension :)

@stefanobartoletti
Copy link
Contributor Author

No problem at all, thanks :)

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the icons and there was still something to do here.

Here you can see the new icons which were originally part of your PR:

The issue that I saw here was that some of the contrast got lost which was more present with the old icons:

This is why I decided to create two separate versions, one for dark and another one for light themes:

On the folder icon, the triangles all have the same white color, because first, this fits better to all other folder icons in this extension and second, it provides a little better contrast.

I already pushed the changes and I hope the changes are fine for you.

@stefanobartoletti
Copy link
Contributor Author

They look great, and are following the same standards as in the official Nuxt branding guidelines :)

@PKief
Copy link
Member

PKief commented Mar 15, 2021

Thank you for the feedback :) I will update the extension on the VS Code Marketplace soon.

@PKief PKief merged commit 7aea44c into material-extensions:master Mar 15, 2021
@stefanobartoletti stefanobartoletti deleted the nuxt-icons branch March 21, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants