From e2c5014c43035cee48a0d347abad9f64d24d5c1c Mon Sep 17 00:00:00 2001
From: MarkBaker <mark@demon-angel.eu>
Date: Wed, 1 Feb 2023 15:40:46 +0100
Subject: [PATCH 1/2] Wizards for defining Number Format masks for Numbers,
 Percentages, Scientific, Currency, and Accounting

---
 CHANGELOG.md                                  |   1 +
 .../Style/NumberFormat/Wizard/Accounting.php  |  79 +++++++++++++
 .../Style/NumberFormat/Wizard/Currency.php    | 108 ++++++++++++++++++
 .../Style/NumberFormat/Wizard/Locale.php      |  37 ++++++
 .../Style/NumberFormat/Wizard/Number.php      |  57 +++++++++
 .../Style/NumberFormat/Wizard/NumberBase.php  |  80 +++++++++++++
 .../Style/NumberFormat/Wizard/Percentage.php  |  40 +++++++
 .../Style/NumberFormat/Wizard/Scientific.php  |  33 ++++++
 .../Style/NumberFormat/Wizard/Wizard.php      |   8 ++
 .../NumberFormat/Wizard/AccountingTest.php    | 102 +++++++++++++++++
 .../NumberFormat/Wizard/CurrencyTest.php      | 101 ++++++++++++++++
 .../Style/NumberFormat/Wizard/NumberTest.php  |  70 ++++++++++++
 .../NumberFormat/Wizard/PercentageTest.php    |  91 +++++++++++++++
 .../NumberFormat/Wizard/ScientificTest.php    |  75 ++++++++++++
 14 files changed, 882 insertions(+)
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Currency.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Locale.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Number.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/NumberBase.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Percentage.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Scientific.php
 create mode 100644 src/PhpSpreadsheet/Style/NumberFormat/Wizard/Wizard.php
 create mode 100644 tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/AccountingTest.php
 create mode 100644 tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/CurrencyTest.php
 create mode 100644 tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/NumberTest.php
 create mode 100644 tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/PercentageTest.php
 create mode 100644 tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/ScientificTest.php

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1ef24bfb3e..be6db25669 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 ### Added
 
 - Support for configuring a Chart Title's overlay [PR #3325](https://github.com/PHPOffice/PhpSpreadsheet/pull/3325)
+- Wizards for defining Number Format masks for Numbers, Percentages, Scientific, Currency and Accounting [PR #3334](https://github.com/PHPOffice/PhpSpreadsheet/pull/3334)
 
 ### Changed
 
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php
new file mode 100644
index 0000000000..803a0e5ac7
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php
@@ -0,0 +1,79 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+
+class Accounting extends Currency
+{
+    /**
+     * @param string $currencyCode the currency symbol or code to display for this mask
+     * @param int $decimals number of decimal places to display, in the range 0-30
+     * @param bool $thousandsSeparator indicator whether the thousands separator should be used, or not
+     * @param bool $currencySymbolPosition indicates whether the currency symbol comes before or after the value
+     *              Possible values are Currency::LEADING_SYMBOL and Currency::TRAILING_SYMBOL
+     * @param bool $currencySymbolSpacing indicates whether there is spacing between the currency symbol and the value
+     *              Possible values are Currency::SYMBOL_WITH_SPACING and Currency::SYMBOL_WITHOUT_SPACING
+     * @param ?string $locale Set the locale for the currency format; or leave as the default null.
+     *          If provided, Locale values must be a valid formatted locale string (e.g. 'en-GB', 'fr', uz-Arab-AF).
+     *          Note that setting a locale will override any other settings defined in this class
+     *          other than the currency code.
+     *
+     * @throws Exception If a provided locale code is not a valid format
+     */
+    public function __construct(
+        string $currencyCode = '$',
+        int $decimals = 2,
+        bool $thousandsSeparator = true,
+        bool $currencySymbolPosition = self::LEADING_SYMBOL,
+        bool $currencySymbolSpacing = self::SYMBOL_WITHOUT_SPACING,
+        ?string $locale = null
+    ) {
+        $this->setCurrencyCode($currencyCode);
+        $this->setThousandsSeparator($thousandsSeparator);
+        $this->setDecimals($decimals);
+        $this->setCurrencySymbolPosition($currencySymbolPosition);
+        $this->setCurrencySymbolSpacing($currencySymbolSpacing);
+        $this->setLocale($locale);
+    }
+
+    protected function getLocaleFormat(): string
+    {
+        $formatter = new Locale($this->fullLocale, NumberFormatter::CURRENCY_ACCOUNTING); // @phpstan-ignore-line
+
+        return str_replace('¤', $this->formatCurrencyCode(), $formatter->format());
+    }
+
+    private function formatCurrencyCode(): string
+    {
+        if ($this->locale === null) {
+            return $this->currencyCode . '*';
+        }
+
+        return "[\${$this->currencyCode}-{$this->locale}]";
+    }
+
+    public function format(): string
+    {
+        if ($this->localeFormat !== null) {
+            return $this->localeFormat;
+        }
+
+        return sprintf(
+            '_-%s%s%s0%s%s%s_-',
+            $this->currencySymbolPosition === self::LEADING_SYMBOL ? $this->formatCurrencyCode() : null,
+            (
+                $this->currencySymbolPosition === self::LEADING_SYMBOL &&
+                $this->currencySymbolSpacing === self::SYMBOL_WITH_SPACING
+            ) ? ' ' : '',
+            $this->thousandsSeparator ? '#,##' : null,
+            $this->decimals > 0 ? '.' . str_repeat('0', $this->decimals) : null,
+            (
+                $this->currencySymbolPosition === self::TRAILING_SYMBOL &&
+                $this->currencySymbolSpacing === self::SYMBOL_WITH_SPACING
+            ) ? ' ' : '',
+            $this->currencySymbolPosition === self::TRAILING_SYMBOL ? $this->formatCurrencyCode() : null
+        );
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Currency.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Currency.php
new file mode 100644
index 0000000000..b25bbfd871
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Currency.php
@@ -0,0 +1,108 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+
+class Currency extends Number
+{
+    public const LEADING_SYMBOL = true;
+
+    public const TRAILING_SYMBOL = false;
+
+    public const SYMBOL_WITH_SPACING = true;
+
+    public const SYMBOL_WITHOUT_SPACING = false;
+
+    protected string $currencyCode = '$';
+
+    protected bool $currencySymbolPosition = self::LEADING_SYMBOL;
+
+    protected bool $currencySymbolSpacing = self::SYMBOL_WITHOUT_SPACING;
+
+    /**
+     * @param string $currencyCode the currency symbol or code to display for this mask
+     * @param int $decimals number of decimal places to display, in the range 0-30
+     * @param bool $thousandsSeparator indicator whether the thousands separator should be used, or not
+     * @param bool $currencySymbolPosition indicates whether the currency symbol comes before or after the value
+     *              Possible values are Currency::LEADING_SYMBOL and Currency::TRAILING_SYMBOL
+     * @param bool $currencySymbolSpacing indicates whether there is spacing between the currency symbol and the value
+     *              Possible values are Currency::SYMBOL_WITH_SPACING and Currency::SYMBOL_WITHOUT_SPACING
+     * @param ?string $locale Set the locale for the currency format; or leave as the default null.
+     *          If provided, Locale values must be a valid formatted locale string (e.g. 'en-GB', 'fr', uz-Arab-AF).
+     *          Note that setting a locale will override any other settings defined in this class
+     *          other than the currency code.
+     *
+     * @throws Exception If a provided locale code is not a valid format
+     */
+    public function __construct(
+        string $currencyCode = '$',
+        int $decimals = 2,
+        bool $thousandsSeparator = true,
+        bool $currencySymbolPosition = self::LEADING_SYMBOL,
+        bool $currencySymbolSpacing = self::SYMBOL_WITHOUT_SPACING,
+        ?string $locale = null
+    ) {
+        $this->setCurrencyCode($currencyCode);
+        $this->setThousandsSeparator($thousandsSeparator);
+        $this->setDecimals($decimals);
+        $this->setCurrencySymbolPosition($currencySymbolPosition);
+        $this->setCurrencySymbolSpacing($currencySymbolSpacing);
+        $this->setLocale($locale);
+    }
+
+    public function setCurrencyCode(string $currencyCode): void
+    {
+        $this->currencyCode = $currencyCode;
+    }
+
+    public function setCurrencySymbolPosition(bool $currencySymbolPosition = self::LEADING_SYMBOL): void
+    {
+        $this->currencySymbolPosition = $currencySymbolPosition;
+    }
+
+    public function setCurrencySymbolSpacing(bool $currencySymbolSpacing = self::SYMBOL_WITHOUT_SPACING): void
+    {
+        $this->currencySymbolSpacing = $currencySymbolSpacing;
+    }
+
+    protected function getLocaleFormat(): string
+    {
+        $formatter = new Locale($this->fullLocale, NumberFormatter::CURRENCY); // @phpstan-ignore-line
+
+        return str_replace('¤', $this->formatCurrencyCode(), $formatter->format());
+    }
+
+    private function formatCurrencyCode(): string
+    {
+        if ($this->locale === null) {
+            return $this->currencyCode;
+        }
+
+        return "[\${$this->currencyCode}-{$this->locale}]";
+    }
+
+    public function format(): string
+    {
+        if ($this->localeFormat !== null) {
+            return $this->localeFormat;
+        }
+
+        return sprintf(
+            '%s%s%s0%s%s%s',
+            $this->currencySymbolPosition === self::LEADING_SYMBOL ? $this->formatCurrencyCode() : null,
+            (
+                $this->currencySymbolPosition === self::LEADING_SYMBOL &&
+                $this->currencySymbolSpacing === self::SYMBOL_WITH_SPACING
+            ) ? "\u{a0}" : '',
+            $this->thousandsSeparator ? '#,##' : null,
+            $this->decimals > 0 ? '.' . str_repeat('0', $this->decimals) : null,
+            (
+                $this->currencySymbolPosition === self::TRAILING_SYMBOL &&
+                $this->currencySymbolSpacing === self::SYMBOL_WITH_SPACING
+            ) ? "\u{a0}" : '',
+            $this->currencySymbolPosition === self::TRAILING_SYMBOL ? $this->formatCurrencyCode() : null
+        );
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Locale.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Locale.php
new file mode 100644
index 0000000000..2253e8120e
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Locale.php
@@ -0,0 +1,37 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+
+final class Locale
+{
+    /**
+     * Language code: ISO-639 2 character, alpha.
+     * Optional script code: ISO-15924 4 alpha.
+     * Optional country code: ISO-3166-1, 2 character alpha.
+     * Separated by underscores or dashes.
+     */
+    public const STRUCTURE = '/^(?P<language>[a-z]{2})([-_](?P<script>[a-z]{4}))?([-_](?P<country>[a-z]{2}))?$/i';
+
+    private NumberFormatter $formatter;
+
+    public function __construct(string $locale, int $style)
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            throw new Exception();
+        }
+
+        $formatterLocale = str_replace('-', '_', $locale);
+        $this->formatter = new NumberFormatter($formatterLocale, $style);
+        if ($this->formatter->getLocale() !== $formatterLocale) {
+            throw new Exception("Unable to read locale data for '{$locale}'");
+        }
+    }
+
+    public function format(): string
+    {
+        return $this->formatter->getPattern();
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Number.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Number.php
new file mode 100644
index 0000000000..d7e7cd07fd
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Number.php
@@ -0,0 +1,57 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use PhpOffice\PhpSpreadsheet\Exception;
+
+class Number extends NumberBase implements Wizard
+{
+    public const WITH_THOUSANDS_SEPARATOR = true;
+
+    public const WITHOUT_THOUSANDS_SEPARATOR = false;
+
+    protected bool $thousandsSeparator = true;
+
+    /**
+     * @param int $decimals number of decimal places to display, in the range 0-30
+     * @param bool $thousandsSeparator indicator whether the thousands separator should be used, or not
+     * @param ?string $locale Set the locale for the number format; or leave as the default null.
+     *          Locale has no effect for Number Format values, and is retained here only for compatibility
+     *              with the other Wizards.
+     *          If provided, Locale values must be a valid formatted locale string (e.g. 'en-GB', 'fr', uz-Arab-AF).
+     *
+     * @throws Exception If a provided locale code is not a valid format
+     */
+    public function __construct(
+        int $decimals = 2,
+        bool $thousandsSeparator = self::WITH_THOUSANDS_SEPARATOR,
+        ?string $locale = null
+    ) {
+        $this->setDecimals($decimals);
+        $this->setThousandsSeparator($thousandsSeparator);
+        $this->setLocale($locale);
+    }
+
+    public function setThousandsSeparator(bool $thousandsSeparator = self::WITH_THOUSANDS_SEPARATOR): void
+    {
+        $this->thousandsSeparator = $thousandsSeparator;
+    }
+
+    /**
+     * As MS Excel cannot easily handle Lakh, which is the only locale-specific Number format variant,
+     *       we don't use locale with Numbers.
+     */
+    protected function getLocaleFormat(): string
+    {
+        return $this->format();
+    }
+
+    public function format(): string
+    {
+        return sprintf(
+            '%s0%s',
+            $this->thousandsSeparator ? '#,##' : null,
+            $this->decimals > 0 ? '.' . str_repeat('0', $this->decimals) : null
+        );
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/NumberBase.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/NumberBase.php
new file mode 100644
index 0000000000..051b7f437c
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/NumberBase.php
@@ -0,0 +1,80 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat;
+
+abstract class NumberBase
+{
+    protected const MAX_DECIMALS = 30;
+
+    protected int $decimals = 2;
+
+    protected ?string $locale = null;
+
+    protected ?string $fullLocale = null;
+
+    protected ?string $localeFormat = null;
+
+    public function setDecimals(int $decimals = 2, ?string $locale = null): void
+    {
+        $this->decimals = ($decimals > self::MAX_DECIMALS) ? self::MAX_DECIMALS : max($decimals, 0);
+    }
+
+    /**
+     * Setting a locale will override any settings defined in this class.
+     *
+     * @throws Exception If the locale code is not a valid format
+     */
+    public function setLocale(?string $locale = null): void
+    {
+        if ($locale === null) {
+            $this->localeFormat = $this->locale = $this->fullLocale = null;
+
+            return;
+        }
+
+        $this->locale = $this->validateLocale($locale);
+
+        if (class_exists(NumberFormatter::class)) {
+            $this->localeFormat = $this->getLocaleFormat();
+        }
+    }
+
+    /**
+     * Stub: should be implemented as a concrete method in concrete wizards.
+     */
+    abstract protected function getLocaleFormat(): string;
+
+    /**
+     * @throws Exception If the locale code is not a valid format
+     */
+    private function validateLocale(string $locale): string
+    {
+        if (preg_match(Locale::STRUCTURE, $locale, $matches, PREG_UNMATCHED_AS_NULL) !== 1) {
+            throw new Exception("Invalid locale code '{$locale}'");
+        }
+
+        ['language' => $language, 'script' => $script, 'country' => $country] = $matches;
+        // Set case and separator to match standardised locale case
+        $language = strtolower($language ?? '');
+        $script = ($script === null) ? null : ucfirst(strtolower($script));
+        $country = ($country === null) ? null : strtoupper($country);
+
+        $this->fullLocale = implode('-', array_filter([$language, $script, $country]));
+
+        return $country === null ? $language : "{$language}-{$country}";
+    }
+
+    public function format(): string
+    {
+        return NumberFormat::FORMAT_GENERAL;
+    }
+
+    public function __toString(): string
+    {
+        return $this->format();
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Percentage.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Percentage.php
new file mode 100644
index 0000000000..19cc702b51
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Percentage.php
@@ -0,0 +1,40 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+
+class Percentage extends NumberBase implements Wizard
+{
+    /**
+     * @param int $decimals number of decimal places to display, in the range 0-30
+     * @param ?string $locale Set the locale for the percentage format; or leave as the default null.
+     *          If provided, Locale values must be a valid formatted locale string (e.g. 'en-GB', 'fr', uz-Arab-AF).
+     *
+     * @throws Exception If a provided locale code is not a valid format
+     */
+    public function __construct(int $decimals = 2, ?string $locale = null)
+    {
+        $this->setDecimals($decimals);
+        $this->setLocale($locale);
+    }
+
+    protected function getLocaleFormat(): string
+    {
+        $formatter = new Locale($this->fullLocale, NumberFormatter::PERCENT); // @phpstan-ignore-line
+
+        return $this->decimals > 0
+            ? str_replace('0', '0.' . str_repeat('0', $this->decimals), $formatter->format())
+            : $formatter->format();
+    }
+
+    public function format(): string
+    {
+        if ($this->localeFormat !== null) {
+            return $this->localeFormat;
+        }
+
+        return sprintf('0%s%%', $this->decimals > 0 ? '.' . str_repeat('0', $this->decimals) : null);
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Scientific.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Scientific.php
new file mode 100644
index 0000000000..2c25efd149
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Scientific.php
@@ -0,0 +1,33 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+use PhpOffice\PhpSpreadsheet\Exception;
+
+class Scientific extends NumberBase implements Wizard
+{
+    /**
+     * @param int $decimals number of decimal places to display, in the range 0-30
+     * @param ?string $locale Set the locale for the scientific format; or leave as the default null.
+     *          Locale has no effect for Scientific Format values, and is retained here for compatibility
+     *              with the other Wizards.
+     *          If provided, Locale values must be a valid formatted locale string (e.g. 'en-GB', 'fr', uz-Arab-AF).
+     *
+     * @throws Exception If a provided locale code is not a valid format
+     */
+    public function __construct(int $decimals = 2, ?string $locale = null)
+    {
+        $this->setDecimals($decimals);
+        $this->setLocale($locale);
+    }
+
+    protected function getLocaleFormat(): string
+    {
+        return $this->format();
+    }
+
+    public function format(): string
+    {
+        return sprintf('0%sE+00', $this->decimals > 0 ? '.' . str_repeat('0', $this->decimals) : null);
+    }
+}
diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Wizard.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Wizard.php
new file mode 100644
index 0000000000..de4dc4f818
--- /dev/null
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Wizard.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
+
+interface Wizard
+{
+    public function format(): string;
+}
diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/AccountingTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/AccountingTest.php
new file mode 100644
index 0000000000..6513a891d4
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/AccountingTest.php
@@ -0,0 +1,102 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Accounting;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Currency;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Number;
+use PHPUnit\Framework\TestCase;
+
+class AccountingTest extends TestCase
+{
+    /**
+     * @dataProvider providerAccounting
+     */
+    public function testCurrency(
+        string $expectedResult,
+        string $currencyCode,
+        int $decimals,
+        bool $thousandsSeparator,
+        bool $currencySymbolPosition,
+        bool $currencySymbolSpacing
+    ): void {
+        $wizard = new Accounting($currencyCode, $decimals, $thousandsSeparator, $currencySymbolPosition, $currencySymbolSpacing);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerAccounting(): array
+    {
+        return [
+            ['_-$* 0_-', '$', 0, Number::WITHOUT_THOUSANDS_SEPARATOR, Currency::LEADING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ['_-$* #,##0_-', '$', 0, Number::WITH_THOUSANDS_SEPARATOR, Currency::LEADING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ['_-$*#,##0_-', '$', 0, Number::WITH_THOUSANDS_SEPARATOR, Currency::LEADING_SYMBOL, Currency::SYMBOL_WITHOUT_SPACING],
+            ['_-0.00 €*_-', '€', 2, Number::WITHOUT_THOUSANDS_SEPARATOR, Currency::TRAILING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ['_-#,##0.00 €*_-', '€', 2, Number::WITH_THOUSANDS_SEPARATOR, Currency::TRAILING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ['_-0.00€*_-', '€', 2, Number::WITHOUT_THOUSANDS_SEPARATOR, Currency::TRAILING_SYMBOL, Currency::SYMBOL_WITHOUT_SPACING],
+        ];
+    }
+
+    /**
+     * @dataProvider providerAccountingLocale
+     */
+    public function testAccountingLocale(
+        string $expectedResult,
+        string $currencyCode,
+        string $locale
+    ): void {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $wizard = new Accounting($currencyCode);
+        $wizard->setLocale($locale);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerAccountingLocale(): array
+    {
+        return [
+            ["[\$€-fy-NL]\u{a0}#,##0.00;([\$€-fy-NL]\u{a0}#,##0.00)", '€', 'fy-NL'],
+            ["[\$€-nl-NL]\u{a0}#,##0.00;([\$€-nl-NL]\u{a0}#,##0.00)", '€', 'nl-NL'],
+            ["[\$€-nl-BE]\u{a0}#,##0.00;([\$€-nl-BE]\u{a0}#,##0.00)", '€', 'NL-BE'],
+            ["#,##0.00\u{a0}[\$€-fr-BE];(#,##0.00\u{a0}[\$€-fr-BE])", '€', 'fr-be'],
+            ["#,##0.00\u{a0}[\$€-el-GR]", '€', 'el-gr'],
+            ['[$$-en-CA]#,##0.00;([$$-en-CA]#,##0.00)', '$', 'en-ca'],
+            ["#,##0.00\u{a0}[\$\$-fr-CA];(#,##0.00\u{a0}[\$\$-fr-CA])", '$', 'fr-ca'],
+            ['[$¥-ja-JP]#,##0;([$¥-ja-JP]#,##0)', '¥', 'ja-JP'], // No decimals
+            ["#,##0.000\u{a0}[\$د.ب‎-ar-BH]", 'د.ب‎', 'ar-BH'],  // 3 decimals
+        ];
+    }
+
+    public function testAccountingLocaleInvalidFormat(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'en-usa';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Invalid locale code '{$locale}'");
+
+        $wizard = new Accounting('€');
+        $wizard->setLocale($locale);
+    }
+
+    public function testAccountingLocaleInvalidCode(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'nl-GB';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Unable to read locale data for '{$locale}'");
+
+        $wizard = new Accounting('€');
+        $wizard->setLocale($locale);
+    }
+}
diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/CurrencyTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/CurrencyTest.php
new file mode 100644
index 0000000000..6647628a5c
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/CurrencyTest.php
@@ -0,0 +1,101 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Currency;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Number;
+use PHPUnit\Framework\TestCase;
+
+class CurrencyTest extends TestCase
+{
+    /**
+     * @dataProvider providerCurrency
+     */
+    public function testCurrency(
+        string $expectedResult,
+        string $currencyCode,
+        int $decimals,
+        bool $thousandsSeparator,
+        bool $currencySymbolPosition,
+        bool $currencySymbolSpacing
+    ): void {
+        $wizard = new Currency($currencyCode, $decimals, $thousandsSeparator, $currencySymbolPosition, $currencySymbolSpacing);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerCurrency(): array
+    {
+        return [
+            ["\$\u{a0}0", '$', 0, Number::WITHOUT_THOUSANDS_SEPARATOR, Currency::LEADING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ["\$\u{a0}#,##0", '$', 0, Number::WITH_THOUSANDS_SEPARATOR, Currency::LEADING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ['$#,##0', '$', 0, Number::WITH_THOUSANDS_SEPARATOR, Currency::LEADING_SYMBOL, Currency::SYMBOL_WITHOUT_SPACING],
+            ["0.00\u{a0}€", '€', 2, Number::WITHOUT_THOUSANDS_SEPARATOR, Currency::TRAILING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ["#,##0.00\u{a0}€", '€', 2, Number::WITH_THOUSANDS_SEPARATOR, Currency::TRAILING_SYMBOL, Currency::SYMBOL_WITH_SPACING],
+            ['0.00€', '€', 2, Number::WITHOUT_THOUSANDS_SEPARATOR, Currency::TRAILING_SYMBOL, Currency::SYMBOL_WITHOUT_SPACING],
+        ];
+    }
+
+    /**
+     * @dataProvider providerCurrencyLocale
+     */
+    public function testCurrencyLocale(
+        string $expectedResult,
+        string $currencyCode,
+        string $locale
+    ): void {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $wizard = new Currency($currencyCode);
+        $wizard->setLocale($locale);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerCurrencyLocale(): array
+    {
+        return [
+            ["[\$€-fy-NL]\u{a0}#,##0.00;[\$€-fy-NL]\u{a0}#,##0.00-", '€', 'fy-NL'], // Trailing negative
+            ["[\$€-nl-NL]\u{a0}#,##0.00;[\$€-nl-NL]\u{a0}-#,##0.00", '€', 'nl-NL'], // Sign between currency and value
+            ["[\$€-nl-BE]\u{a0}#,##0.00;[\$€-nl-BE]\u{a0}-#,##0.00", '€', 'NL-BE'], // Sign between currency and value
+            ["#,##0.00\u{a0}[\$€-fr-BE]", '€', 'fr-be'],   // Trailing currency code
+            ["#,##0.00\u{a0}[\$€-el-GR]", '€', 'el-gr'],   // Trailing currency code
+            ['[$$-en-CA]#,##0.00', '$', 'en-ca'],
+            ["#,##0.00\u{a0}[\$\$-fr-CA]", '$', 'fr-ca'],   // Trailing currency code
+            ['[$¥-ja-JP]#,##0', '¥', 'ja-JP'], // No decimals
+            ["#,##0.000\u{a0}[\$د.ب‎-ar-BH]", 'د.ب‎', 'ar-BH'],  // 3 decimals
+        ];
+    }
+
+    public function testCurrencyLocaleInvalidFormat(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'en-usa';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Invalid locale code '{$locale}'");
+
+        $wizard = new Currency('€');
+        $wizard->setLocale($locale);
+    }
+
+    public function testCurrencyLocaleInvalidCode(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'nl-GB';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Unable to read locale data for '{$locale}'");
+
+        $wizard = new Currency('€');
+        $wizard->setLocale($locale);
+    }
+}
diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/NumberTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/NumberTest.php
new file mode 100644
index 0000000000..28189f1f47
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/NumberTest.php
@@ -0,0 +1,70 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Number;
+use PHPUnit\Framework\TestCase;
+
+class NumberTest extends TestCase
+{
+    /**
+     * @dataProvider providerNumber
+     */
+    public function testNumber(string $expectedResult, int $decimals, bool $thousandsSeparator): void
+    {
+        $wizard = new Number($decimals, $thousandsSeparator);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerNumber(): array
+    {
+        return [
+            ['0', 0, Number::WITHOUT_THOUSANDS_SEPARATOR],
+            ['#,##0', 0, Number::WITH_THOUSANDS_SEPARATOR],
+            ['0.0', 1, Number::WITHOUT_THOUSANDS_SEPARATOR],
+            ['#,##0.0', 1, Number::WITH_THOUSANDS_SEPARATOR],
+            ['0.00', 2, Number::WITHOUT_THOUSANDS_SEPARATOR],
+            ['#,##0.00', 2, Number::WITH_THOUSANDS_SEPARATOR],
+        ];
+    }
+
+    /**
+     * @dataProvider providerNumberLocale
+     */
+    public function testNumberLocale(
+        string $expectedResult,
+        string $locale
+    ): void {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $wizard = new Number(2);
+        $wizard->setLocale($locale);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerNumberLocale(): array
+    {
+        return [
+            ['#,##0.00', 'en-us'],
+        ];
+    }
+
+    public function testNumberLocaleInvalidFormat(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'en-usa';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Invalid locale code '{$locale}'");
+
+        $wizard = new Number(2);
+        $wizard->setLocale($locale);
+    }
+}
diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/PercentageTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/PercentageTest.php
new file mode 100644
index 0000000000..e29fd1e1c6
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/PercentageTest.php
@@ -0,0 +1,91 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Percentage;
+use PHPUnit\Framework\TestCase;
+
+class PercentageTest extends TestCase
+{
+    /**
+     * @dataProvider providerPercentage
+     */
+    public function testPercentage(string $expectedResult, int $decimals): void
+    {
+        $wizard = new Percentage($decimals);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerPercentage(): array
+    {
+        return [
+            ['0%', 0],
+            ['0.0%', 1],
+            ['0.00%', 2],
+            ['0.000%', 3],
+            ['0%', -1],
+            ['0.000000000000000000000000000000%', 31],
+        ];
+    }
+
+    /**
+     * @dataProvider providerPercentageLocale
+     */
+    public function testPercentageLocale(
+        string $expectedResult,
+        string $locale
+    ): void {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $wizard = new Percentage(2);
+        $wizard->setLocale($locale);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerPercentageLocale(): array
+    {
+        return [
+            ['#,##0.00%', 'fy-NL'],
+            ['#,##0.00%', 'nl-NL'],
+            ['#,##0.00%', 'NL-BE'],
+            ["#,##0.00\u{a0}%", 'fr-be'],
+            ['#,##0.00%', 'el-gr'],
+            ['#,##0.00%', 'en-ca'],
+            ["#,##0.00\u{a0}%", 'fr-ca'],
+        ];
+    }
+
+    public function testPercentageLocaleInvalidFormat(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'en-usa';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Invalid locale code '{$locale}'");
+
+        $wizard = new Percentage(2);
+        $wizard->setLocale($locale);
+    }
+
+    public function testPercentageLocaleInvalidCode(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'nl-GB';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Unable to read locale data for '{$locale}'");
+
+        $wizard = new Percentage(2);
+        $wizard->setLocale($locale);
+    }
+}
diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/ScientificTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/ScientificTest.php
new file mode 100644
index 0000000000..d32c2380b0
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Style/NumberFormat/Wizard/ScientificTest.php
@@ -0,0 +1,75 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests\Style\NumberFormat\Wizard;
+
+use NumberFormatter;
+use PhpOffice\PhpSpreadsheet\Exception;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard\Scientific;
+use PHPUnit\Framework\TestCase;
+
+class ScientificTest extends TestCase
+{
+    /**
+     * @dataProvider providerScientific
+     */
+    public function testScientific(string $expectedResult, int $decimals): void
+    {
+        $wizard = new Scientific($decimals);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerScientific(): array
+    {
+        return [
+            ['0E+00', 0],
+            ['0.0E+00', 1],
+            ['0.00E+00', 2],
+            ['0.000E+00', 3],
+            ['0E+00', -1],
+            ['0.000000000000000000000000000000E+00', 31],
+        ];
+    }
+
+    /**
+     * @dataProvider providerScientificLocale
+     */
+    public function testScientificLocale(
+        string $expectedResult,
+        string $locale
+    ): void {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $wizard = new Scientific(2);
+        $wizard->setLocale($locale);
+        self::assertSame($expectedResult, (string) $wizard);
+    }
+
+    public function providerScientificLocale(): array
+    {
+        return [
+            ['0.00E+00', 'en'],
+            ['0.00E+00', 'az-AZ'],
+            ['0.00E+00', 'az-Cyrl'],
+            ['0.00E+00', 'az-Cyrl-AZ'],
+            ['0.00E+00', 'az-Latn'],
+            ['0.00E+00', 'az-Latn-AZ'],
+        ];
+    }
+
+    public function testScientificLocaleInvalidFormat(): void
+    {
+        if (class_exists(NumberFormatter::class) === false) {
+            self::markTestSkipped('Intl extension is not available');
+        }
+
+        $locale = 'en-usa';
+
+        self::expectException(Exception::class);
+        self::expectExceptionMessage("Invalid locale code '{$locale}'");
+
+        $wizard = new Scientific(2);
+        $wizard->setLocale($locale);
+    }
+}

From 7ec1969faeb84adca34e7cf299cad7517d965a74 Mon Sep 17 00:00:00 2001
From: MarkBaker <mark@demon-angel.eu>
Date: Fri, 3 Feb 2023 18:24:47 +0100
Subject: [PATCH 2/2] Accounting Format PHP Intl Extension and ICU version
 checks (minimum PHP 7.4.1 and ICU 53)

---
 .../Style/NumberFormat/Wizard/Accounting.php   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php
index 803a0e5ac7..3e23bedf9a 100644
--- a/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php
+++ b/src/PhpSpreadsheet/Style/NumberFormat/Wizard/Accounting.php
@@ -38,13 +38,31 @@ public function __construct(
         $this->setLocale($locale);
     }
 
+    /**
+     * @throws Exception if the Intl extension and ICU version don't support Accounting formats
+     */
     protected function getLocaleFormat(): string
     {
+        if (version_compare(PHP_VERSION, '7.4.1', '<')) {
+            throw new Exception('The Intl extension does not support Accounting Formats below PHP 7.4.1');
+        }
+
+        if ($this->icuVersion() < 53.0) {
+            throw new Exception('The Intl extension does not support Accounting Formats without ICU 53');
+        }
+
         $formatter = new Locale($this->fullLocale, NumberFormatter::CURRENCY_ACCOUNTING); // @phpstan-ignore-line
 
         return str_replace('¤', $this->formatCurrencyCode(), $formatter->format());
     }
 
+    private function icuVersion(): float
+    {
+        [$major, $minor] = explode('.', INTL_ICU_VERSION);
+
+        return (float) "{$major}.{$minor}";
+    }
+
     private function formatCurrencyCode(): string
     {
         if ($this->locale === null) {