Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xlsx Writer's handling of decimal commas #1282

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

makedin
Copy link
Contributor

@makedin makedin commented Dec 10, 2019

Perform the comma -> period substitution in Xlsx Writer writeCell()
before checking if the decimal value has a period in it. The previous
behavior led to decimals of the form "1,1" to become "1.1.0".

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

See #1281

Perform the comma -> period substitution in Xlsx Writer writeCell()
before checking if the decimal value has a period in it. The previous
behavior led to decimals of the form "1,1" to become "1.1.0".
@MarkBaker
Copy link
Member

Thanks you for this solution to the locale problem

@MarkBaker MarkBaker merged commit ab4c660 into PHPOffice:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants