Convert cell value to numbeic (float) in processDomElementDataFormat #3443
Conversation
If we want to use data-format attribute in html, we have to cast cell value to float (number). because format not applied to string values. We should know excel put Leading apostrophes " ' " to numeric string values. Leading apostrophes force excel to treat the cell's contents as a text value.
|
I think you have identified a problem, but not a proper solution. Here's a basic program to parse html. $reader = new \PhpOffice\PhpSpreadsheet\Reader\Html();
$spreadsheet = $reader->loadFromString($html);
$sheet = $spreadsheet->getActiveSheet();
var_dump($sheet->getCell('A1')->getValue());
var_dump($sheet->getCell('A1')->getFormattedValue());
var_dump($sheet->getStyle('A1')->getNumberFormat()->getFormatCode());Now, let's look at some possible input: <table>
<tr>
<td data-format="#.000">3</td>
</tr>
</table>This works correctly with or without your change - <table>
<tr>
<td data-format="#.000">x</td>
</tr>
</table>This works correctly, or at least the same way as Excel, before your change - <table>
<tr>
<td data-format="mmm-yy">2019-02-02 12:34:00</td>
</tr>
</table>Here, the existing test does not go far enough. It verifies that the format is set correctly, but doesn't check what Of course, date/time strings may not be the only problem. I think you have a specific problem in mind. What is the specific problem that prompted you to submit this PR? |
|
Yes thank you for your good explanation. you are right I think I had this problem in older versions. |
Fix PHPOffice#3443. A mysterious implementation by Excel. The style tags have an attribute applyAlignment, which nominally says whether or not the style should use its own Alignment. Except ... Excel ignores that attribute and uses the alignment tag if it is supplied ... and, another mystery, uses not the default style for the spreadsheet if not supplied, but rather uses the default alignment style for all spreadsheets even if the spreadsheet's default style uses a non-default alignment. I am changing Xlsx Writer to generate alignment tag unless the alignment matches both the default alignment for the spreadsheet and the default alignment for all spreadsheets (which I expect to happen most of the time).
* Xlsx Writer Honor Alignment in Default Font Fix #3443. A mysterious implementation by Excel. The style tags have an attribute applyAlignment, which nominally says whether or not the style should use its own Alignment. Except ... Excel ignores that attribute and uses the alignment tag if it is supplied ... and, another mystery, uses not the default style for the spreadsheet if not supplied, but rather uses the default alignment style for all spreadsheets even if the spreadsheet's default style uses a non-default alignment. I am changing Xlsx Writer to generate alignment tag unless the alignment matches both the default alignment for the spreadsheet and the default alignment for all spreadsheets (which I expect to happen most of the time). * Improve Performance Also don't change horizontal/vertical on Xlsx Read if they aren't explicitly set.
If we want to use data-format attribute in html, we have to cast cell value to float (number). because format not applied to string values. We should know excel put Leading apostrophes " ' " to numeric string values. Leading apostrophes force excel to treat the cell's contents as a text value.