Feature/csv variable columns #1415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…each individual row. Sometimes CSV files contain content that isn't intended as a column header, and may not align with proceeding values as columns. In this case, proceeding rows should not be filled with blanks to match the column count of the longest row. This adds a new flag to the Csv Writer, letting the user override the default behavior of exporting a range based on the highest row and highest column overall, instead calculating the range on a per row basis so that "shorter" rows are not filled with blanks.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Writer/Csv has changed just enough that this code can no longer be used. I will see if I can salvage it. |
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Jun 27, 2024
Supersedes PR PHPOffice#1415 by @AndrewMonty, which went stale in May 2020, and which is not directly usable due to changes between now and then. Fix PHPOffice#1414, which also went stale; I will remove the stale status and reopen the issue pending the merging of this PR. Add an option to CSV Writer so that it writes the cells for a row only through the highest data column used in the row, rather than through the highest data column used in the worksheet.
10 tasks
|
Superseded by PR #4076. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
#1414
Sometimes CSV files contain content that isn't intended as a column header, and
may not align with proceeding values as columns. In this case it's likely undesirable
to have proceeding rows filled with blanks to match the column count of the longest row.