TCPDF - PDF generation does not respect $isPDF

[Collie-IT]

This is:

• a bug report
• a feature request
• not a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

If I use TCPDF as writer, the $isPDF in /vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Writer/Html.php should interpreted as true.

What is the current behavior?

If I use TCPDF as writer, the $isPDF is misinterpreted in/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Writer/Html.php as false.

What are the steps to reproduce?

<?php

require __DIR__ . '/vendor/autoload.php';

// Create new Spreadsheet object
$spreadsheet = new \PhpOffice\PhpSpreadsheet\Spreadsheet();

// add code that show the issue here...
$sheet = $spreadsheet->getActiveSheet();
$sheet->setCellValue("A1" , "Test");
$writer = \PhpOffice\PhpSpreadsheet\IOFactory::createWriter($spreadsheet, 'Tcpdf');
$writer->setEmbedImages(true) ;
$writer->generateHTMLHeader() ;
$writer->generateStyles(true) ;
$writer->generateHTMLFooter() ;
$writer->save($path2); 

Which versions of PhpSpreadsheet and PHP are affected?

Tested with 1.8.2, 1.9.0.

[Collie-IT]

The dirty hot fix is set to $isPDF to public in html.php.

[PowerKiKi]

What is the consequences of having this flag to the wrong flag? Why do you think it needs to be changed?

[Collie-IT]

The Problem is that the pagebreaks will be doubled, if $isPDF is false, because <path>vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Writer/Html.php on Line 828 checks for if not PDF

PhpSpreadsheet/src/PhpSpreadsheet/Writer/Html.php

Lines 828 to 830 in 9d6736d

	if (!$this->isPdf) {
	$css['table']['page-break-after'] = 'always';
	}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[oleibman]

Setting isPdf was added to PDF constructor by PR #1464 in May 2020.