From df9e0da514dabf207b530ed6fe9366931e6d4f47 Mon Sep 17 00:00:00 2001 From: oleibman <10341515+oleibman@users.noreply.github.com> Date: Wed, 15 Feb 2023 22:21:15 -0800 Subject: [PATCH] Additional Functions Coverage for Reader Xls (#3371) PR #3340 increased coverage in Reader Xls for most functions. Some of the omissions from that PR (see below) were intended from the start. However, the set of (BINOMDIST, EXPONDIST, GAMMADIST, NORMDIST, POISSON, WEIBULL, and FIXED) were not intended to be omitted; they just did not seem to work. Having had time to research, it appears that the problem is not those functions themselves, but rather the use of Boolean constants as function arguments (see issue #3369). Knowing that, it is possible to add those missing functions back in, just taking care to use `0` or `1` or `TRUE()` or `FALSE()` rather than boolean constants as arguments. No update to source or test code; just adding a few new cells to an Xls spreadsheet. Functions still omitted because they return array results: - GROWTH - LINEST - LOGEST - MINVERSE - MMULT - TRANSPOSE - TREND Functions still omitted because they are not implemented in PhpSpreadsheet: - BAHTTEXT - CELL - FREQUENCY - GETPIVOTDATA --- tests/data/Reader/XLS/formulas.database.xls | Bin 13824 -> 26624 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/Reader/XLS/formulas.database.xls b/tests/data/Reader/XLS/formulas.database.xls index bd18d0eb56405fc07c29bc39ce352f5d5abd6616..26add4903713108fc3f178141412477bfc71747d 100644 GIT binary patch literal 26624 zcmeHwcU%-n(|_->z@i{Q1p$R6sDR{X!X>B}KoIj85OE2DperDra&U+NBVtzWOsAq4 zF{79d4@E@;J@iyCogU^>Iqy#Qt(w_kcZc1@=l6b|KYs6r#-5$2srpuRb#+g7Pw!fB z-LQ7cL9;r-N_~h1`6AIFT5@y_oVzpE1_bU)BzVbuy1_Y+TGIbV9?;=KMQUl1Z$htX zmk}<};uBH_p9gs7;7G_r$m7T~qDx5VOi`jBSQIyDYGk6|znuao8zMPq!&wMCUpV8C ze4rWe!Y#?x*-pQAb~5MAAqYDW53z=nm2Z`;&K8^9Yj+N4Yia$NlNiBFCi6&SwD=XD@{VqcEDj%Fu9a>$R;3kFFP^MtXGg8Ot-4gh$)Mfj)$a z!@q!mN=$pVS3!4FL3dC}Zx5Kt+Iwq;-WdOM9Kx`X=C6XG7a^7~YNN`fqewSq=&fXQ z0U?>td}#hgI;$VUdB}U5ZLsKV7@S7G(Q#$S(5uKqI5lJN^%#1i{dC;6W9a#YhQ_Up z!T)r7)Mw~`Py3&)7ku6;^S?I3&$1H=&iE&ikUow6Y0J=A{8-+h8UjLc;e<+O1#|fA z$Q*QZWAY;_QjMRb^PNb#0=+kIaETr~7c}4uGd@(|apcejp5UBxzCTLOnld2E^S%5rkcSPXJL}er{9KT^qIH0}#f~5_yMlc~E}5 zQTqCtM0NS?6hQKcmU0luC3PU(6+uR+utZXyFK5XLR&{yXmE>4t(4Hx`D~+L)TCgPP`Od>-o0yLlu#&aVw60MF$!r? zn+Ri+JguowF!+-*>hE+F?p9`$yjT8ro?^E~A25n;Na+10Mls4HnVd#XH7%J#W67}n zV^SK@+qZ9T1Yu%8-nEP}dD_>zo82(`fEjed#F9Z>DaJrLKaCa1J%CM#hr zx{&r=l(BeVXwd8^W1DtQ)*vP8S>Zwv7~R8wK=(ueHwD2Vh76>Mbu@@5THd;*Aov_> z7Nk5_JqSz@n+Iv^<5d*LMgasal>0;zZm9MN4ilO!jwo6^2#)od1t||!4+1md=0V&& z)PvY6fWU=vpWxs^wNG%!*=%t{(dt2PKGZBod9ZpAi?0E3_fQYgSpfttl=}n+ZmNBP z!?b3LBZ^iJV)`{8<-zJfVC2}mCGH;TLAoe_z=d+3;FwaiPjJZm6+Tf90t55rLCS;G zg9yF`#N9(ZNLK|AxKQpBoY1KD2~L~7!YArM%)bVtJXk%5)z^Tyd&q;VYv> zuBJU(jdxQu?rPNF>Lbk()OdbHq?HFBF8y7(8WXk}C6Q*M zMvZ)=l?VTIWv_BI9oTA=L|RuhYUCrWJoxV2yUNv=vehVwv~FtD$VXavu;l4_ zYLrBpiyAfZkyajDa{HBXHRfzJN+QiejT-q#D-SNMJ*-?!M^xjjKGFoB#``NG&D~?! zE){jtiLFLSq}i%bBOht*9`6riD=&=&TaA)Pvs0r+KGNJh%F4==tFdIOQ4(p6YShR_ zn!AUjCR(`~0b7ldNOM)AMn2NqJvN?ys$7i~TaA)P^HifoKGNJhc2z7>rbZWDSi!if z@ww^GdTw@-Xsdiy64FopjIqU`6wdfWxAVkP+J)*^ zGYeEcW(YOerk?6-OFPRzAzIj=_AF5O2!SG>CCV-BA_IlkV1qibK;`3skg*%9m4kMb zfkGs(LETuO^0iOMw7o&fK>5TD9(yDpa&jKOhhoih%q1Em09F+zH$ECQaqR;Z0@06n zj;n>z8aIG9lCaDk7?}{2k`S33mz0>t|6UQ0Ybce|hSf3A!6-C7h0!0Z4dHf8P zT_%!NU{@>*2BSzk3=IR}ECK%Ht-`gMCgH!G&Mj;Ah={I{6&HRgdneDrWWwpv3Rv$r<06VK*qw8V0@#DQzj2&y0Bz;5rzs^Wk7l8pH#xv@x}hl`Rb~9ViV&JuH?3XNroIa^nGk_LnYvJ|EB_6BHVhs4hn+c9`fMO2eQG9 zlz`LypbBt$XuzewJ>|inFJyHH8f}$;V}D53n6|uIFlxOr`Awsi%cnqQK@fJupc z#!F+c6^v$Jt!QB4v=j)R6vb-hwgVpwgxZ(}@r!{X>oO$pN`R?od~fi->@p095B6oj zaf$Jw$K=p zl31NNrz3RcLjV{{Duy`3&WN6#P<=4GM`6mF4=-D!jRe9llYq;u6>a4ZP&ouzhnVVA z5DL2$9nu4v)R3fPQ67Jiq6oJYG$|BG1{-iKo9Uc!Et~1}a2;CK7t>cvuSZ`oy&iqF zlG_?Kp}@LVXi73w!82J(+XHkcRph2sEdNx%PE?_aksz~#zG5t)uNX_{D~!%wnVR4# zTSXHzHNo#;RAe%11GKYRk=_`Y!{d?@z*}yLQX2YD8^a+OlA)f^UrieXXC=24@ueV= zlCi>B%M%)=6a+e)u52C^Lkdd}=y#^8p-anLVMG~{KJWk~qawwL*sIY!uu#!ZZfoew zM}Y=0#4XdYDeHOhIZt_b8GkfcCby1)FLn*#Z#aNVqDngqOrAxZg+SS{zf6HJa|bWR zkyI*zWE}E)`n<_RY8T@?C{-A~JA%j<7Aq1ZyKUfiARFX#a_}Z3ByEG8pWEc_A$X7wz~L|Mw%kh5~35GhYcJO6x^?4r*j-WIR|K7f3zY0l5pG5v1;fQ6 z5k%$yQCv)HGF0@KI8nl6=+OLQkQ^pXijG6F|FmfdB47^_MT&tAg9@>D7O?eka|f-x zdq`j#C!d7ETP&ywvJ5^4!)FxV7&4qlld<%(h^*m{(p@8WM{fz2gbmiXx(R>X`GxKbanQHbLZd!>i!F;9ct_Mi&m~=0seN5tuqX zJ=5#QoELX*jY&9lZ&}f@Io=b>hn$nNoA^QatnJP6jIkNu5eW=Y75%mS*3RG0f}gyh zo*@`Wgjkd?!^Iho*~_m_x!|h1;Pt$cxi`{>R$l1PIn`x*ZlKGybW&%R5o>LJ*S!92 z=q0UIC;8bwy>8g$`(@waPj#z)7Z`8Yt##pHpzum;U8?VyjI6SGKke+yADcF9{ns|7y^T_7?BtwM7KPo)dhipUtRi^nYlGSQ77&C zO)9#w@8m}km~ZBPX>;YKySJY_n(K4zLA&aWgZ0KZ=4jzLUfTA-z+YwzO}DAeowxVMJ;ALb-Kwo#JKmdc!gh-9;-FE_ZZ_CI z>{s8dODk@7<;D-GoO3`+c zet-MZMOpieQ^#)Ky**-Xz@Ud^t%}3;C3u&oUZr#=mhXj@qP|ID~>!=VV`g=? z%PrkqpWK)H_2I#TjJnSs>h)hoe77>OWQj?aFZZrToc`zYa{XNk+Wx*H?Vp#0GxtZ7 ze126Z%=q?s#px?I&Sp0Z%$_$hGqfbgF-xQ8UynFv^7{(=Ud;2edX`#{c%_1CQEre@ zXZEXiUE4NeN;OaU_#Qp}F`&=tiwFO_;98V9zBG33^qm}w-6guM8+J~wy`LW%@|#We zka4qph9>kl?i(T~Fs(GM9ncEFqDO#46Y*f?enewuq>mflWbw(g_U*=w&^o0oN7e?0k> zO=j&vSpEilB&p(`D;4)-e$5s`QyoPV~23ZwNSzB!UD(#2qS29daT&g|Y z`)KUA+S5GKIdP@~UhF8>o_aH=>W)BvU7swi3#$|TFN!mqxBju)cw^5er5{5!p5&O> z6h6oqFemZPLscJFNq#tbX}Zt2&jC!SCFSCT&J(5nfjpNnp#bo41%qVHQ8;^MJs&$v*RmB(BvY6{|ldOo?~u_^ZD zFEPP(FUw4S{wE+bo!9%ulAZ?&9=|`{Hpb?xZT9}%<>$1FoofeNNy{(0o})Y4YS2W_ z;qO=H`IV2*K0kO}X3mNUseg=2>$$WzVbzeHi~D(12X`y;8UD>JV|S0~D2|`=%T$Sn^X$@kCE;o%Evk$e}Y19N$~zGVaKEZh>gR z_d$vJ7FG4%o#0suco(|IUJtq)x~tISe)Y9eLqhj^>}b!anB-zDXh;s3K7MxZlw!{+ z=i0c%*@lVUI#W&W)#eyjWdD9+*GQLuM@6UiJ#jwr%zoIj&w|5Zv+BE+lctY|nERVJ zar43T_OUO1xb^w+NYjAmg?Yuo`8jTLmKrVWwB^TQ1HIZKSHj-CpMPdh^uXh}PPXT( zYI{EasYYOJG-G*Q!K=bYF#vGQYQxy+ZH>+c4c?~}_aw?jd&sdLmRySJy=uqZrR_z} z-y6Bl+0ZTj%#^oyB4MzvmqW-8Kvf@Z4_~?H*d!b9GGe`w`I^kEVPV?OG6-H_NIcZ}-^^{g3R9 z8|f9^Ccg01r+~}i{*~qNJ64YvUY#7{7QdjM>FA;-)r(G@n-V$cm$>M8p~D))m-jk} z?}cy59iiiz7A*{_F7fksEqJnVOjWx_)t-CAALmr>>$F(o$H14?{m%dL_v(3fI-eAI zoj=jZal)>5;IOLmm1#FdO&MH2>gm(5Q@y*-e|#g$dFG()75lPloP#P1J|u_cZP#-u z{u6g&Hhq5U-N@Z^6z-VA(;eU9%0B|>K?_BZdx}d3F(IwaySB@2$ePJdO1fEWu%gSo zg%x|NG_oIi>3IunhrW2Jx6hI9ydd)Q`nZ#8e<*7k<$m8ScDEV7=kwLmH=LV#{KYcA zaN{94HN7Sun3%OJ$>(MJm=%NVLb}+7+c~?f6SwI)Xk~uIqT!!1_jTX4eB@*6Z9Dvb zIax8FAtinD+l`z#Kiif}GMHUWOxJ{MkR1Bl-7F`@#nO2Em!bYMYUXL$Z7nUYwb{5k zn0I+>aq-0mjYa2honXI@s!=Vl$t5LY+_1rl0PJC&OxhLvDL3e23$lkzGC@-qPs&#U z+x=`L_83NnbW0f$HKJi-u!BH`Q3H!e^46#ciLk+%FqFbsx+WP9rLV#{4cQ1YrHyh^ z3%Eg+0BwmJ4f&9n{yv?7!uRP~b8$BeoiIM9z#h*LLik>tKY`a0@RcH%;&5TUr%#<5 z!jZr#AfNoZ>uqJoq%dIwMR%a+-Kb+0MaiTlHZ*Q$n1{nwLGnG^IR}#-LfS)~OL1pY z$1aWB&xH8p8ah1_+BKfP5!%b0Z^5tM03yx@IWV!q2^F1c!FEiwLj5!Our8X|hLz2x zL9{fXVa>Ana9YZy;qG!a4NJ#il?}I@v1vw1XgEz}^I_exX;{~68cqh-G@PchX&9Sq z8tznL({QH_n})L`HVrpz$f>4> z#gA)*$nQY$P{_m@&l~a4E}1>Ja)SIcr!yr*;hznc;-lpaLJ{EU}%p!H$@!rYVhvJR2=GWr=>pp+A%T!yKu zfQh}93{w|sO;&Td3Ygf->En_()P^U%;gDiN>-VGP+!71eO@vi-mUq@fi^NikN1b&r zbb#V-N6BHUp>4r3V;@PHk+Y}duw_Z*h%?9mPBU^2lpMA`M$Q4`0H+zbZj>ChP)5!j zBT_J!sF(I+Z$bc^ba1& z@F*03HS*mj(yWxwtd-Dgl+bLI(4eU`(b0uP(}FLU34jI;95VNF<%Xx=BJh-?J+aUr z7JOnEO{H5xe{14z$kBqg-)N>jY0#eKn6#z>*g;%kgzT0Z)?+#$wBQi`4#3-)8e8ZS z~5puLWi4d@1avg^U^i95K+1yV8_ppamL zGcei{^bPpo0enyq0)k)K63ce`g6h8gcDWzg3orgP;GF`zntZ=rOKy z2)vASA&vm!1wi(s4{U!ts)c=$AL2>VVi->@Rv1TdVGSPoQ+lApfdLbqy@rU@gm-F$ z#PCfZGvfH7goC?AH2TuxP}vRjXI~`9kIx0g1ZI=kd7IvS3XL@=T)`*Zx*n==1=<0~ zP(lbF+I}8<4uFi7OoWW(N`s8gjaU?K&gOzJx{_pr{AI|@Og^cUCIR6iWjO%No zA>&#i&iiqrSSDng+b@KS^Zs1OxJJ1SGOh<~hK%b2hak(Z2Xuhz{*iHF!N3`jkx_!c zB=NK)G4%xq+_8(vfWpT!)PsrrX#tASHe92i_dpU|AfXyuazOS`N#gh!xIJ543oo#RDxKXz@Uc2UOzjPMmShj`Mfi!HM&Joa5u3EPUsW^L%F4DbDqAJpkwPxaSA=@8EA*;ch|v znLC__TS68<#{WCS8a{0x+d{@Y8Mxg7H#^ut#`_NN*$uKIWGBeZkX<0VLdN@_A>(ID z`p-QO4&N)qugVJG=LGQgyYMFj{*z=(G^u?js2Sr(z{evYXQ?CXc9KhiEq7aG!QKq4 zD~3D@w2R@3-;*di;u-Q+f5QI)(x@M8_*%hV{b^23GK~6`E&fIXmL0zpA5GbW6xokz wsKT`a{n&=E{d}!{D+I&F14)zg1#S2v9#i2vzgPqRnLXYAAIfi!ilzGh2jG6eEC2ui delta 1064 zcmZuv&rcIk5dPlVZP^0SQd-K7wlpMq5Dzw*5EQVL#tR-aLX0LP7z$#791JGJgX{rr z8i6_JQ7(oX(T&EFDK}$c^e8v@0}OaDF+_RJds~Ano$T&6nfcx~v-8IND%_dnv!Z<^ z-)Xl2czu0CkP?ylt6iV#HY-5bqPTo1n#hwU#V~Ejl9;8el?i<3t<34!kSO8-?%@t* zkVgkT!bT&O1;Ee$S+6G?vgm!oIITCfEeJ&LQ{{kP+<>u4ZW{@N*)NKmiTIyNj--v4 zYblM*ZrEVlwGFnobp{izV-PM3Cf$%47m_8G(1cMf%i1@lCnx9fPhiKmJAqB%@C$T* z5On#>*v)StaPL5h>BEc@PLf}J)VE|6-_)}cabheP!{N|?2AQZ*fG+l$>ww=U=yBgQ zq3BCr=hzy$Ijl@|!IL_)?MuF|aTF304O1-<4$c6*IjM^z!;-;z8!p{$?rZuR#_dp`c@4^;-U-mAeY(&j^o_6n(lu0MS$ zDit410|!~8QZ!I(qjSaE=LcmR@5~++nD);yh(ccyo4!SDyS%6&^s-m)?UY`K)sk(6 zq@>-6B&ADlo##)N7JIjZ#mTNH?F~7HgjULoJhRr@8@!E?`%(KqDMh(*+II@&v{xw? i#L9Sib!vvb4>>e9wI~sz{i#R7p@(-D8qI$BONPJQKeYh>