Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds onto the changes made in PR #52 by @gapple and PR #52 should be merged first (if accepted). After that, this PR should be rebased to make it mergeable. Please feel free to ping me to rebase.
Proposed Changes
precise
image instead of thetrusty
image for which PHP 5.3 is no longer available.All PHPCS sniffs are unit tested and written to give the same results on all supported PHP versions, so there is no need for the PHPCS check to be run on each and every build.
Using the
SNIFF
environment variable, the PHPCS check is now run only on the PHP 7.2 build.All relevant settings are already contained in the
phpcs.xml.dist
file and PHPCS will automatically use that file if found, so there is no need to pass these parameters on the command-line.N.B.: Previously, i.e. pre-PR Execute phpcs and security-checker from vendor/bin #52, the PHPCS check would have been run before the
composer install
which meant that thePHPCompatibility
standard used would not (yet) be available.As PR Execute phpcs and security-checker from vendor/bin #52, changed the order in which these commands are run, the
PHPCompatibility
standard should now be available at the time of running PHPCS.N.B.: The
composer install
command which is part of the script appears to exit with a time-out at the moment. This is unrelated to this PR, but may need attention.