-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds static function to call the Plugin::onDependenciesChangedEvent() method #5
Conversation
@Potherca Will do 👍 |
@frenck Update complete, can be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, but missing some code documentation.
src/Plugin.php
Outdated
$this->init(); | ||
} | ||
|
||
private function init() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation block.
Could you please add this?
src/Plugin.php
Outdated
@@ -55,6 +60,19 @@ class Plugin implements PluginInterface, EventSubscriberInterface | |||
*/ | |||
private $processBuilder; | |||
|
|||
public static function run(Event $event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation block.
Could you please add this?
Docblocks fixed. |
Thx! |
Fix for issue #4.
This PR expose a new method
run
. This can be use from acomposer.json
file like this:Beside this feature I have also done some minor code cleanup and added more message for in verbose mode.