numeric_literal_separator breaks numbers < 1

[keradus]

original code:

<?php echo 0.001;
is modified into
<?php echo 0._001;
which is syntax error

[keradus]

@muuvmuuv want to take a look, please?

[muuvmuuv]

Do you have a few more cases so I can add them all to the tests? Kinda weird that it adds a underscore here.

[keradus]

I had previous case, you fixed it, it allowed me to discover new case.
This is not only unexpected that _ is added, but also making code invalid.

I am not familiar with more failing cases yet, i hope none will be there.

[muuvmuuv]

Problem with this case is that I cannot test it actually because the test suite only accepts code to be not the exact match than expected code. Hm, any idea?

Yeah, this one is critical, will try to fix it asap.

[keradus]

in data provider, use expected param and keep input param missing/null

[Wirone]

@muuvmuuv Just don't add this case to yieldCases() (which provides two-way testing), but provide separate test case like do not override existing separator. Or you can modify yieldCases() to return null instead of input if both are the same. The reason behind yieldCases() was to simplify testing for converting in both directions (add or remove separator), but it was prepared for cases where input and expected value was different.

[muuvmuuv]

Oh... well :D haven't thought that through well enough

Hmm. Actually, I don't know how I should "except" this case prior 8.1. Maybe to also check for "dots" in the string but idk sounds dirty/hacky. Any ideas?