Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR: 'pathogen inhibition of host defense induced acidification in phagolysome' #317

Closed
CuzickA opened this issue Mar 2, 2021 · 8 comments

Comments

@CuzickA
Copy link
Contributor

CuzickA commented Mar 2, 2021

For PHI-base/curation#36

image

@ValWood I think this section needs some re-structuring

In the WT metagenotype see 'pathogen inhibition of host defense induced acidification in phagolysome', which could not go under an 'abnormal heading'

and we discussed changing the term label for 'pathogen-induced pH decrease in host phagolysome' to 'host defense induced acidification in phagolysome'

Perhaps 'abnormal pathogen-induced host pH' should change to something more general like 'pathogen host interaction pH phenotype', remove the increase/ decreased grouping terms if they are not used (to check??) and position 'pathogen inhibition of host defense induced acidification in phagolysome' and 'host defense induced acidification in phagolysome' under ''pathogen host interaction pH phenotype'. What do you think @ValWood?

@ValWood
Copy link

ValWood commented Mar 3, 2021

this sounds good.

@CuzickA
Copy link
Contributor Author

CuzickA commented Mar 3, 2021

@jseager7 please could you check if these terms have been used in annotations? Thanks

PHIPO:0001109 abnormal pathogen-induced host pH
PHIPO:0001110 pathogen-induced decrease in host pH
PHIPO:0001111 pathogen-induced increase in host pH
PHIPO:0001112 pathogen-induced pH decrease in host phagolysome

@jseager7
Copy link
Contributor

jseager7 commented Mar 3, 2021

@CuzickA None of these terms show up in the export, but the last export was made on 27 January so it's pretty out of date. Unfortunately I can't make another export at the moment because there's an error in the export script. You should be fine if you're confident that you haven't made any pH annotations since then.

@CuzickA
Copy link
Contributor Author

CuzickA commented Mar 8, 2021

Can I just rename 'abnormal pathogen-induced host pH' to 'pathogen host interaction pH phenotype'?

See #241
It looks like we had a term for 'pathogen host interaction pH phenotype' which was obsoleted. Does this need to be unobsoleted?

@CuzickA
Copy link
Contributor Author

CuzickA commented Mar 8, 2021

http://wiki.geneontology.org/index.php/Restoring_an_Obsolete_Ontology_Term
Followed this to restore PHIPO:0001108 pathogen host interaction pH phenotype
f380b2f

@CuzickA
Copy link
Contributor Author

CuzickA commented Mar 8, 2021

change term label
PHIPO:0001113 pathogen-induced pH decrease in host phagolysome ->
host defense induced acidification in phagolysome
old def
A pathogen host interaction phenotype where the pathogen induces a pH decrease within the host phagolysome.
new def
A pathogen host interaction phenotype where the host induces a pH decrease within the host phagolysome in response to pathogen colonization.

ea1693a

@CuzickA
Copy link
Contributor Author

CuzickA commented Mar 8, 2021

NTR: pathogen inhibition of host defense induced acidification in phagolysome

and edit to PHIPO:0001113 definition

b2f9273

CuzickA added a commit that referenced this issue Mar 8, 2021
CuzickA added a commit that referenced this issue Mar 8, 2021
…golysome and edit to PHIPO:0001113 definition

#317
@CuzickA
Copy link
Contributor Author

CuzickA commented Mar 8, 2021

Obsolete
PHIPO:0001109 abnormal pathogen-induced host pH
PHIPO:0001110 pathogen-induced decrease in host pH
PHIPO:0001111 pathogen-induced increase in host pH

d446293

Now looks like this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants