Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'gene-for-gene' curation sessions with new GfG AE #82

Closed
CuzickA opened this issue Sep 30, 2020 · 10 comments
Closed

Update 'gene-for-gene' curation sessions with new GfG AE #82

CuzickA opened this issue Sep 30, 2020 · 10 comments

Comments

@CuzickA
Copy link

CuzickA commented Sep 30, 2020

PHI-base/phipo#272

#65 DONE

@CuzickA
Copy link
Author

CuzickA commented Oct 6, 2020

#19 DONE

@CuzickA
Copy link
Author

CuzickA commented Oct 7, 2020

#73 DONE

@CuzickA
Copy link
Author

CuzickA commented Oct 7, 2020

This gene-for-gene curation session is incomplete and needs work
https://canto.phi-base.org/curs/6dd9062354648dc7
#62

@CuzickA
Copy link
Author

CuzickA commented Oct 9, 2020

#22 DONE

Next check with @ValWood and Kim H-K whether we are happy with changes to these four gene-for-gene sessions.

@CuzickA CuzickA changed the title Update 'gene-for-gene' curation sessions with modified AE 'infective ability Update 'gene-for-gene' curation sessions with new GfG AE Nov 23, 2020
@CuzickA
Copy link
Author

CuzickA commented Nov 23, 2020

New AE for Gene-for-Gene now enabled
Need to update all sessions again and remove old AEs. Once this is done, curation type can be switched from PHI phenotype to Gene for gene phenotype and sessions can be reviewed with Val and Kim H-K.
#65 Avr1/Sen1 DONE
#73 Avrstb6/Stb6 DONE
#19 Atr1/RPP1 DONE
#62 Avr4/Cf4 incomplete session to review DONE
#22 Tox1/Snn1 DONE

@CuzickA
Copy link
Author

CuzickA commented Dec 4, 2020

I believe I have removed all the old gene-for-gene AE and replaced with the new compound terms.

@jseager7 please go ahead and check if I have got them all and then switch the sessions over to the Gene-for-Gene Phenotype work flow. Thanks.
PMID:31246152
PMID:29434355
PMID:20601497
PMID: 30148881
PMID:22241993

Next: Review the usage of the new compound AEs with Val and Kim H-K.

@jseager7
Copy link

jseager7 commented Dec 7, 2020

@CuzickA the only remaining annotations with the old gene-for-gene extensions are in the two test sessions (PMID:100900 and PMID:1). I don't think it will be a problem to leave these as they are since I'm going to be testing this change locally first. We should still be able to delete the old extensions even after the annotations are transferred to gene-for-gene phenotypes.

@CuzickA
Copy link
Author

CuzickA commented Dec 7, 2020

Thanks @jseager7 I forgot about the two test sessions!
let me know how the local changes go

@jseager7
Copy link

jseager7 commented Dec 8, 2020

@CuzickA The local changes were fine, so I'll start applying the changes to the demo server first, then the main server. With regards to the old extensions that will be left over in the test sessions, I've confirmed that we can still remove them from annotations even after the annotations are transferred to the new type.

@CuzickA
Copy link
Author

CuzickA commented Dec 11, 2020

Currently reviewing sessions with Val and Kim H-K.

Closing ticket for now.

@CuzickA CuzickA closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants