Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welch PSD Example Problem #10

Open
tgterra opened this issue Sep 6, 2019 · 1 comment
Open

Welch PSD Example Problem #10

tgterra opened this issue Sep 6, 2019 · 1 comment
Assignees
Labels
review required Improvement or non-bug issue that requires further review

Comments

@tgterra
Copy link

tgterra commented Sep 6, 2019

Hello Pedro,

When I try to run the frequency domain Welch PSD example with SampleECG.txt file I got a different plot figure
welch_example

Example code:

`
import biosppy
import pyhrv.frequency_domain as fd
from opensignalsreader import OpenSignalsReader

signal = OpenSignalsReader('SampleECG.txt').signal('ECG')
rpeaks = biosppy.signals.ecg.ecg(signal)[2]
result = fd.welch_psd(rpeaks=rpeaks)`

When the result should be:
image

@PGomes92
Copy link
Owner

PGomes92 commented Sep 15, 2019

Hi @tgterra,

The issue is due to the current SampleECG.txt containing a signal of too short duration for a proper PSD computation. It might happen that I have replaced the SampleECG.txt over the last months and didn't update the output results in the pyHRV documentation.

The new update will come with a feature load sample NNI series which come with pyHRV in order to avoid this confusion.

I will fix the documentation along with it and apologies for the confusion that this caused!

Edit: Accidentally closed this issue and my reply too soon. I reopened this issue and completed my response.

@PGomes92 PGomes92 self-assigned this Sep 15, 2019
@PGomes92 PGomes92 added the review required Improvement or non-bug issue that requires further review label Sep 15, 2019
@PGomes92 PGomes92 reopened this Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review required Improvement or non-bug issue that requires further review
Projects
None yet
Development

No branches or pull requests

2 participants