Corrections to playerColor values #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the current color values are a bit off (15, 17, 18) and a couple are very wrong (11/brown is given the same value as 9/lightblue, 20/coal is given a kind of green/aqua). See the differences here: https://codepen.io/bearand/pen/GRgMyMG Corrected values are based on https://docs.google.com/spreadsheets/d/1wzWIYzRW9pqpo1ZuEcU-qJTg-H4z5-PaTnHIXPezaRQ, from HiveWorkshop: https://www.hiveworkshop.com/threads/wc3-editor-player-colors-reference.306608/
|
Great find and thank you for opening a PR. Can you adjust the test cases to pass again? I can merge it afterwards. |
|
OK, tests look good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the current color values are a bit off (15, 17, 18) and a couple are very wrong (11/brown is given the same value as 9/lightblue, 20/coal is given a kind of green/aqua). See the differences in this codepen.
Corrected values are based on this data, from HiveWorkshop