Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENEActive not parsing the tz/dst correctly #203

Open
angerhang opened this issue Jun 28, 2022 · 3 comments · Fixed by #211
Open

GENEActive not parsing the tz/dst correctly #203

angerhang opened this issue Jun 28, 2022 · 3 comments · Fixed by #211
Assignees

Comments

@angerhang
Copy link
Member

At the moment, GENEActive devices are reading local time as if they are true unix time, which is incorrect. This will create issues for daylight savings and different time zones. Something like AX3 needs to be done for GENEActive devices.

@angerhang
Copy link
Member Author

@chanshing do we have an estimated timeline on this on this or I will do the change myself? I need to get this done soon to start training my model?

@chanshing
Copy link
Member

@chanshing do we have an estimated timeline on this on this or I will do the change myself? I need to get this done soon to start training my model?

Sorry Hang, just reading this. I assumed you would fix it as you're probably more familiar with the GENEActiv device than me.

@chanshing chanshing removed their assignment Sep 28, 2022
@angerhang angerhang reopened this Apr 4, 2023
@angerhang
Copy link
Member Author

angerhang commented Apr 4, 2023

I have to reopen this because bba currently doesn't deal with daylight saving and time zone properly. I am having a hot fix in my code to manually move the data back by one hour. But need to raise this issue for future awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants