Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on WSL 2 Ubuntu 20.04 - primarily node-pty #57

Closed
peterdresslar opened this issue Dec 24, 2021 · 1 comment
Closed

Build fails on WSL 2 Ubuntu 20.04 - primarily node-pty #57

peterdresslar opened this issue Dec 24, 2021 · 1 comment

Comments

@peterdresslar
Copy link

Not particularly surprising, at the moment, but I thought I would document what's going on.

bcrypt is not at all happy at 0.3.1 on node 14 or node 16. Updating to ^0.5.1 in package.json remedies this, but I have not tested this possibly breaking change.

node-pty is breaking npm install for me on any of node 12, 14, or 16 (all lts). Upgrading to the latest (0.9.1 -> 0.10.0) changes the output but does not solve. This problem could be specific to the fact that I am running Ubuntu on WSL 2. Simply cloning the latest version of node-pty also fails for me in this environment: issue report here.

This isn't a failure for angband-webclient but might be worth noting that there is a lot of mirror-gazing going on with node-pty. My next test is to just try and build on native Ubuntu on a docker instance. I suspect that node versions are going to still be tricky with some of the current dependencies--we'll see.

@peterdresslar
Copy link
Author

Builds fine in a Docker Dev container using node 16. Surely this is a WSL 2 issue--closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant