Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Async issue with PrivateRoute #260

Open
tombeckenham opened this issue Dec 8, 2024 · 0 comments
Open

[BUG] Async issue with PrivateRoute #260

tombeckenham opened this issue Dec 8, 2024 · 0 comments
Assignees

Comments

@tombeckenham
Copy link
Collaborator

Describe the Bug

PrivateRoute calls isUnlocked as if it were a synchronous method. This is returning a promise of a boolean which is always truthy. That's allowing the the user to get to the route regardless of whether the wallet is unlocked or not

Expected experience

I should not be able to get to routes that expected an unlocked wallet

Steps To Reproduce

  1. Unlock a wallet
  2. Go to the dashboard

I should be redirected to unlock but instead I get to see the dashboard

Environment

- OS: Mac
- Node: 20
- npm:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code Review
Development

No branches or pull requests

1 participant