Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT - Submission to PyOpenSci Peer Review Process #1223

Closed
14 of 15 tasks
Zeitsperre opened this issue Nov 7, 2022 · 1 comment
Closed
14 of 15 tasks

DRAFT - Submission to PyOpenSci Peer Review Process #1223

Zeitsperre opened this issue Nov 7, 2022 · 1 comment
Assignees
Labels
information For development/intsructional purposes standards / conventions Suggestions on ways forward
Milestone

Comments

@Zeitsperre
Copy link
Collaborator

Zeitsperre commented Nov 7, 2022

This is the issue template for the PyOpenSci Peer Review Process (related to #95). If people want to help with the editing of this document, It would be greatly appreciated.

The PyOpenSci guide notes the difference between maintainers and authors for the peer-review process, as maintainers would be those responsible for responding to requests for changes. I've indicated myself, @tlogan2000 and @aulemahal as having this role, but all those who work on xclim will be credited for their work on it.

For more information, see: https://www.pyopensci.org/peer-review-guide/software-peer-review-guide/author-guide.html#pyopensci-review-guide-for-python-open-source-package-maintainers-and-authors


Submitting Author: Trevor James Smith (@Zeitsperre)
All current maintainers: (@Zeitsperre, @tlogan2000, @aulemahal)
Package Name: xclim
One-Line Description of Package: Climate indices computation package based on Xarray
Repository Link:  https://github.com/Ouranosinc/xclim
Version submitted: v0.39.0
Editor: TBD  
Reviewer 1: TBD  
Reviewer 2: TBD  
Archive: TBD  
Version accepted: TBD 
Date accepted (month/day/year): TBD


Description

xclim is an operational Python library for climate services, providing numerous climate-related indicator tools with an extensible framework for constructing custom climate indicators, statistical downscaling and bias adjustment of climate model simulations, as well as climate model ensemble analysis tools.

xclim is built using xarray_ and can seamlessly benefit from the parallelization handling provided by dask_. Its objective is to make it as simple as possible for users to perform typical climate services data treatment workflows. Leveraging xarray and dask, users can easily bias-adjust climate simulations over large spatial domains or compute indices from large climate datasets.

Scope 

  • Please indicate which category or categories this package falls under:
        - [ ] Data retrieval
        - [ ] Data extraction
        - [x] Data munging
        - [ ] Data deposition
        - [x] Reproducibility
        - [x] Geospatial
        - [ ] Education
        - [ ] Data visualization*

Please fill out a pre-submission inquiry before submitting a data visualization package. For more info, see notes on categories of our guidebook.

  • For all submissions, explain how and why the package falls under the categories you indicated above. In your explanation, please address the following points (briefly, 1-2 sentences for each): 

  - Who is the target audience, and what are scientific applications of this package?

xclim aims to position itself as a climate services tool for any researchers interested in using Climate and Forecast Conventions compliant datasets to perform climate analyses. This tool is optimized for working with Big Data in the climate science domain and can function as an independent library for one-off analyses in Jupyter notebooks or as a backend engine for performing climate data analyses over PyWPS (e.g. Finch). It was primarily developed targeting earth and environmental science audiences and researchers, originally for calculating climate indicators for the Canadian government web service ClimateData.ca.

The primary domains that xclim is built for are in calculating climate indicators, performing statistical correction / bias adjustment of climate model output variables/simulations, and in performing climate model simulation ensemble statistics.

  - Are there other Python packages that accomplish the same thing? If so, how does yours differ?

icclim is another library for the computation of climate indices. Starting with version 5.0 of icclim, some of the core computations rely on xclim. See explanations about differences between xclim and icclim.

scikit-downscale is a library offering algorithms for statistical downscaling. xclim drew inspiration for its fit-predict architecture. The suite of downscaling algorithms offered differ.

Technical checks

For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box.  This package:

  • does not violate the Terms of Service of any service it interacts with. 
  • has an OSI approved license.
  • contains a README with instructions for installing the development version. (Under CONTRIBUTING)
  • includes documentation with examples for all functions.
  • contains a vignette with examples of its essential functions and uses.
  • has a test suite.
  • has continuous integration, such as Travis CI, AppVeyor, CircleCI, and/or others.

Publication options

 JOSS Checks  
  • The package has an obvious research application according to JOSS's definition in their submission requirements. Be aware that completing the pyOpenSci review process does not guarantee acceptance to JOSS. Be sure to read their submission requirements (linked above) if you are interested in submitting to JOSS.
  • The package is not a "minor utility" as defined by JOSS's submission requirements: "Minor ‘utility’ packages, including ‘thin’ API clients, are not acceptable." pyOpenSci welcomes these packages under "Data Retrieval", but JOSS has slightly different criteria.
  • The package contains a paper.md matching JOSS's requirements with a high-level description in the package root or in inst/.
  • The package is deposited in a long-term repository with the DOI: 

Note: Do not submit your package separately to JOSS
  

Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?

This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.

  • Yes I am OK with reviewers submitting requested changes as issues to my repo. Reviewers will then link to the issues in their submitted review.

Code of conduct

Please fill out our survey

P.S. *Have feedback/comments about our review process? Leave a comment here

Editor and Review Templates

Editor and review templates can be found here

@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward information For development/intsructional purposes labels Nov 7, 2022
@Zeitsperre Zeitsperre added this to the v0.40 milestone Nov 7, 2022
@Zeitsperre Zeitsperre modified the milestones: v0.40, v0.41 Dec 5, 2022
@Zeitsperre
Copy link
Collaborator Author

Submitted! pyOpenSci/software-submission#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
information For development/intsructional purposes standards / conventions Suggestions on ways forward
Projects
None yet
Development

No branches or pull requests

4 participants