Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools::test() fails on Master #322

Closed
pbchase opened this issue Mar 1, 2021 · 2 comments
Closed

devtools::test() fails on Master #322

pbchase opened this issue Mar 1, 2021 · 2 comments
Assignees

Comments

@pbchase
Copy link
Contributor

pbchase commented Mar 1, 2021

devtools::test() throws 24 errors when run against the master branch, commit 79b43a. This is on a Mac, RStudio 1.3.1093, R 4.0.1.

==> devtools::test()

Loading REDCapR
Testing REDCapR
✓ |  OK F W S | Context
✓ |   2       | column-sanitize [0.1 s]
✓ |  16       | constant
✓ |   9       | create-batch-glossary
✓ |  82       | file-oneshot [10.3 s]
✓ |  17       | instrument [3.6 s]
✓ |  17       | metadata-read [1.5 s]
✓ |   2       | metadata-utilities
✓ |  10       | metadata-write [0.6 s]
✓ |   7       | next-free-record-name [1.6 s]
x |  17 1     | project [13.3 s]
───────────────────────────────────────────────────────────────────
test-project.R:45: failure: read-insert-and-update
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >
───────────────────────────────────────────────────────────────────
x |  46 6     | read-batch-longitudinal [11.8 s]
───────────────────────────────────────────────────────────────────
test-read-batch-longitudinal.R:58: failure: default
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-longitudinal.R:73: failure: default
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-longitudinal.R:99: failure: filter-numeric
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-longitudinal.R:114: failure: filter-numeric
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-longitudinal.R:140: failure: filter-character
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-longitudinal.R:155: failure: filter-character
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >
───────────────────────────────────────────────────────────────────
x | 130 17     | read-batch-simple [47.3 s]
───────────────────────────────────────────────────────────────────
test-read-batch-simple.R:45: failure: default
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:60: failure: default
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:116: failure: specify-forms
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:131: failure: specify-forms
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:154: failure: raw
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:169: failure: raw
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:192: failure: raw-and-dag
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:207: failure: raw-and-dag
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:231: failure: label-and-dag-one-single-batch
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:253: failure: label-and-dag-three-tiny-batches
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:276: failure: label
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:291: failure: label
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:316: failure: label-header
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:338: failure: export_checkbox_label
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:353: failure: export_checkbox_label
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:374: failure: filter-numeric
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >

test-read-batch-simple.R:396: failure: filter-character
The returned data.frame should be correct not equal to `expected_data_frame`.
Attributes: < Length mismatch: comparison on first 2 components >
───────────────────────────────────────────────────────────────────

══ Terminating early ══════════════════════════════════════════════
Too many failures
Warning message:
replacing previous import ‘vctrs::data_frame’ by ‘tibble::data_frame’ when loading ‘dplyr’ 
@wibeasley
Copy link
Member

@pbchase, first of all, thanks for PR #323.

I'm not sure about those failures. Maybe you have older package versions on your local machine? It R version of 4.0.1 is kinda old too.

Your PR test code runs well on

I'm hoping the problem is related to package differences, instead of OS differences. Is it possible to update R & packages on that mac to test?

@pbchase
Copy link
Contributor Author

pbchase commented Mar 2, 2021

I updated everything and the errors disappeared. Sorry for the distraction.

@pbchase pbchase closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants