-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split mode normal screen ( Add fullscreen APIs ) #146
Comments
You mean like native fullscreen in Chrome? Not with an option, but I'll add it. Maybe a boolean For now tho you can do it manually in the source pretty easily. I think you can just change this line (401): EpicEditor/epiceditor/js/epiceditor.js Line 401 in 68997cb
to be |
I mean something like this. It's split screen, however I didn't have to press F11 to enter "full screen mode." It would replace the "switch to preview mode" because it would be split screen for previewing, without requiring full screen. It'd be nice to have as an option. |
No, again, but it'd be super easy to add. I'll add an API call to enter fullscreen as well as being able to turn off native fullscreen so that you could do like: var editor = new EpicEditor({ useNativeFullscreen: false });
editor.load(function () {
editor.fullscreen();
}); And it'd look like your example. I'll try to get both of these in. |
That'd be great! |
@bootstraponline quick question, would you rather have |
I'd prefer |
…s the useNativeFullscreen option. Added docs and tests.
@bootstraponline Alright, pull develop! I've added the fullscreen API stuff. There's 2 new methods enterFullscreen and exitFullscreen as well as 2 new events fullscreenenter and fullscreenexit and an option to useNativeFullscreen so you can turn off native fullscreen if you want. Let me know if this is what you expected and is working well! |
Also I did an example for you :) http://jsbin.com/aketom (http://jsbin.com/aketom/edit) Less code than originally expected, now just: var editor = new EpicEditor();
editor.load(function () {
editor.enterFullscreen();
}); |
Wow! That's perfect. |
Glad to hear that! |
Is it possible to have a split mode without forcing the user to enter full screen?
The text was updated successfully, but these errors were encountered: