-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some websites (like GitHub) appear flat when their DOM clearly isn't #10
Comments
same for gmail |
Forcing |
Looking into why
Most pages affected by this issue are probably due to one of these attributes on one of the top-most elements of the page. Forcing most of these values shouldn't have too surprising of an effect (we're not trying to keep the exact same page layout anyways), but |
In gmail's case, it appears to be because |
That's great info! Not entirely what "require the user agent to create a flattened representation" is referring to in the spec, I'll have to go digging. I think this approach of actually looking at the spec for each issue point is the only way this gets to be ~100% reliable. I found that forcing I agree that exact same layout is unnecessary but it would be good to get as close as possible, in some cases this layout change can be quite extreme such as in #14 — it may be a cause of other rendering issues too which we can't easily see while the layout changes unpredictably. |
Adding your comment from the Force isolation: auto PR as it had some good insights:
|
This one is self explanatory, some DOMs are entirely flat when they should not be. There is probably something in the body styling or elsewhere that effects all downstream styling changes, but I'm not sure what.
The text was updated successfully, but these errors were encountered: