From 5dd84023b81b68e80f0a413a2f1fbbcbed25f9b8 Mon Sep 17 00:00:00 2001 From: kostasdano Date: Wed, 9 Aug 2023 17:11:16 +0300 Subject: [PATCH 1/3] fix: select option click handler not triggered --- src/components/Select/Select.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/components/Select/Select.tsx b/src/components/Select/Select.tsx index 9f34ccf5c..93e0ae77c 100644 --- a/src/components/Select/Select.tsx +++ b/src/components/Select/Select.tsx @@ -310,8 +310,11 @@ const Select = React.forwardRef Date: Wed, 9 Aug 2023 17:11:29 +0300 Subject: [PATCH 2/3] feat: add documentation for table --- src/components/Table/Table.stories.mdx | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/components/Table/Table.stories.mdx b/src/components/Table/Table.stories.mdx index 6410a9f1a..00c604e36 100644 --- a/src/components/Table/Table.stories.mdx +++ b/src/components/Table/Table.stories.mdx @@ -59,6 +59,19 @@ import { Table } from '@orfium/ictinus'; +### Disclaimer + +In case of importing data produced using useMemo or external const, follow this pattern: + +```js +import { Row } from '@orfium/ictinus/dist/components/Table/Table'; +... +const data: Row = useMemo(() => {}, []); +//or other types of data +``` + +Where Row is the type from the Table, so you must import it from there. + # Regular Table Regular Table with simple rows From 455408149528f6c0ffdaa7581e7266fba57727a0 Mon Sep 17 00:00:00 2001 From: kostasdano Date: Fri, 11 Aug 2023 11:34:20 +0300 Subject: [PATCH 3/3] feat: add chromatic delay globally --- .storybook/preview.tsx | 1 + src/components/Chart/Chart.stories.mdx | 7 +------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.storybook/preview.tsx b/.storybook/preview.tsx index 2b8610d7b..e259a4440 100644 --- a/.storybook/preview.tsx +++ b/.storybook/preview.tsx @@ -131,4 +131,5 @@ export const parameters = { viewports: viewPorts, }, options: { showPanel: true }, + chromatic: { delay: 2000 }, }; diff --git a/src/components/Chart/Chart.stories.mdx b/src/components/Chart/Chart.stories.mdx index 5e341045e..3f1377576 100644 --- a/src/components/Chart/Chart.stories.mdx +++ b/src/components/Chart/Chart.stories.mdx @@ -8,12 +8,7 @@ import DonutChartShowCase from '../storyUtils/DonutChartShowCase'; import { color } from './LineChart/story.utils'; import { initData } from './LineChart/mockedData'; - + # LineChart