Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Extent to be multipolygon #23

Open
FHunt-OS opened this issue May 30, 2022 · 3 comments
Open

Allow Extent to be multipolygon #23

FHunt-OS opened this issue May 30, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@FHunt-OS
Copy link
Collaborator

It would be useful if Extent could be a multipolygon to allow query results from non-contiguous areas, without needing to make multiple extent/API objects.

@E-Paine
Copy link
Contributor

E-Paine commented Aug 19, 2022

This is not easily solved, at the moment. The underlying API does not support MultiPolygons or multiple geospatial filters. Therefore, a significant amount of post-processing would need to be done, which breaks away from the idea of this being a fairly thin wrapper of the API. This issue should stay open for when this is implemented upstream.

@E-Paine E-Paine added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 22, 2022
@ian-astun
Copy link

Since it only takes the extent of the polygon it should be easy to make it take a multipolygon. I can filter out the bits I don't want later if necessary.

@Ilkka-LBL
Copy link

A related issue is that using Extent.from_ons_code() method doesn't work because some ONS codes are interpreted as multipolygons. One example is that of Greenwich (E09000011), which shouldn't even result in a multipolygon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants