Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of Lombiq.Tests.UI (OCC-102) #212

Closed
sarahelsaig opened this issue Oct 17, 2022 · 2 comments · Fixed by #217
Closed

Upgrade to the latest version of Lombiq.Tests.UI (OCC-102) #212

sarahelsaig opened this issue Oct 17, 2022 · 2 comments · Fixed by #217
Assignees
Labels
enhancement New feature or request

Comments

@sarahelsaig
Copy link
Contributor

sarahelsaig commented Oct 17, 2022

Is your feature request related to a problem? Please describe

The version currently used runs the tested webapp as a separate process (harder to debug) whereas version 4.0.1 uses WebApplicationFactory to instantiate the webapp in the same process. This involves some breaking changes, so it's also necessary in case we will need additional features from the library in the future.

Describe the solution you'd like

  • Upgrade version
  • Make necessary changes according to migration docs here.
  • Review updated OC testing docs here.

Jira issue

@sarahelsaig sarahelsaig added the enhancement New feature or request label Oct 17, 2022
@github-actions github-actions bot changed the title Upgrade to the latest version of Lombiq.Tests.UI Upgrade to the latest version of Lombiq.Tests.UI (OCC-102) Oct 17, 2022
@DemeSzabolcs DemeSzabolcs self-assigned this Oct 20, 2022
@DemeSzabolcs
Copy link
Contributor

DemeSzabolcs commented Oct 20, 2022

@DAud-IcI What do you think about migrating to the new .NET 6.0 hosting model, in this issue? We already use this in other projects (example: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/blob/dev/src/Lombiq.OSOCE.Web/Program.cs). I have to do things in Program.cs anyway, so this could be a good opportunity. (It should be really easy)

@sarahelsaig
Copy link
Contributor Author

I'm in favor of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants