#124: Convert much compiletime configuration to runtime flags #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like all of your changes except for the |
Instead of specifying `./configure.sh --with-dl=both`, specify `-fdlextra` or `MKD_DLEXTRA` at runtime.
I missed this manpage earlier.
This change is more invasive and difficult for me as not all existing
preprocessor directives directly translate to `if () {}`.
Instead of passing `--with-fenced-code` to `configure.sh`, now use
`MKD_FENCEDCODE` or `-ffencedcode`.
The output of `markdown -VV` will now display `FENCEDCODE` if the
feature is enabled and `!FENCEDCODE` if it is disabled rather than
displaying `FENCED-CODE` if the feature is enabled.
Now specify flag `-fidanchor` or `MKD_IDANCHOR` instead of `./configure.sh --with-id-anchor`. In `markdown -VV` displays as `IDANCHOR` or `!IDANCHOR` rather than `ID-ANCHOR`.
Instead of `./configure.sh --with-github-tags`, specify `-fgithubtags` or `MKD_GITHUBTAGS`. Shows up in `markdown -VV` as `GITHUBTAGS` instead of `GITHUB-TAGS` now.
Instead of `./configure.sh --with-urlencoded-anchor`, now use `-furlencodedanchor` or `MKD_URLENCODEDANCHOR`.
|
OK, I pulled those commits out. |
Orc
pushed a commit
that referenced
this pull request
Jul 13, 2015
#124: Convert much compiletime configuration to runtime flags
|
Danka, and merged! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #124.
I generated a lot of changesets because I converted each configurable item independently to avoid confusing myself.
I also added
.gitignoreand.dir-locals.elto make working with the code easier for me. I hope you don’t mind—you’re actually using sccs instead of git yourself? :-pThe change I’m most concerned about is the code fencing one as that didn’t translate directly from
#ifintoif (), if you see what I mean regarding theswitch ()inmarkdown.c. I think I got the logic right, though maybe you have a better way to lay it out or want to simplify it somehow with a macro.