Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VSO API version 2.0 #8

Merged
merged 10 commits into from
Dec 24, 2015
Merged

Support for VSO API version 2.0 #8

merged 10 commits into from
Dec 24, 2015

Conversation

robi26
Copy link
Contributor

@robi26 robi26 commented Dec 23, 2015

Support for the new 2.0 API to get build definitions.
Also supporting longer titles.
Fixes #7

@on5sl
Copy link
Contributor

on5sl commented Dec 23, 2015

I've taken a quick debug session, it's throwing some exceptions in some edge cases. I'll need to investigate this further before i can approve. Suddenly some build URI's are empty in this new API version for example, causing runtime exceptions.

@robi26
Copy link
Contributor Author

robi26 commented Dec 23, 2015

Feel free to send me any bugs or cases so I can fix them.

on5sl added a commit that referenced this pull request Dec 24, 2015
Support for VSO API version 2.0
@on5sl on5sl merged commit c61a46f into OrbitOne:master Dec 24, 2015
@on5sl
Copy link
Contributor

on5sl commented Dec 24, 2015

Thanks Robi! I've done some more testing and did a very few small bugfixes. I also removed some of your styling changes i'm sorry :)
But a big thanks for making this possible! The crowd was waiting for it :)

@robi26 robi26 deleted the buildv2 branch December 28, 2015 10:37
@robi26 robi26 restored the buildv2 branch January 4, 2016 07:55
@robi26 robi26 deleted the buildv2 branch January 4, 2016 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants