Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hodlminer reports incorrect hash rates with high thread count #1

Closed
Orava2 opened this issue Jan 22, 2018 · 1 comment
Closed

Hodlminer reports incorrect hash rates with high thread count #1

Orava2 opened this issue Jan 22, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@Orava2
Copy link
Owner

Orava2 commented Jan 22, 2018

The miner threads run in a while loop. Number of hashes is counted per thread. Hash rate is calculated per thread by deviding hash rate by time. Time is not measured from the beginning of the while loop. This causes hodlminer to overestimate hash rate. Error is very high if you use much higher thread count than your core count is. High thread count causes delays which are outside of the time measurements.

Reported total hash rate is the sum of thread hasrates. This works accurately only if every thread finishes at the same time. If this doesn't happen we need to wait slower threads and the waiting time is not included to calculations.

@Orava2 Orava2 added the bug Something isn't working label Jan 22, 2018
@Orava2
Copy link
Owner Author

Orava2 commented Jan 22, 2018

I fixed the code so that time is measured from the beginning of the while loop.

Total hash count is calculated including all threads. The count is devided by the time which is the longest thread excecution time. In this way the waiting needed for slowest thread is included in calculations.

The fix in added to the source code but new binaries are not build.

@Orava2 Orava2 closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant