Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<code> on dark backgrounds #1036

Closed
2 tasks done
louismaximepiton opened this issue Jan 11, 2022 · 0 comments · Fixed by #1038
Closed
2 tasks done

<code> on dark backgrounds #1036

louismaximepiton opened this issue Jan 11, 2022 · 0 comments · Fixed by #1038
Labels

Comments

@louismaximepiton
Copy link
Member

louismaximepiton commented Jan 11, 2022

Prerequisites

Proposal

Implement the tag <code> on dark backgrounds and re-introduce it in the example in accordions.

Differents solutions that have seen so far, and that we are confused about the one to choose :

  • Adding a background to <code> and a fix color to its text. Issue: Change every code, even for example code. Not good.
  • Find a fixed color that goes well for black and white background color at least (#767676 seems to do it on AA level). Issue: not flexible + not AAA level.
  • Change in every component the text color for <code>. Issue: Not easy to maintain.
  • Change the color value to inherit. Issue: Hard to differenciate from the normal text.

Motivation and context

Dark variants of components

@julien-deramond julien-deramond mentioned this issue Jan 12, 2022
20 tasks
@louismaximepiton louismaximepiton linked a pull request Jan 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant