Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRITICAL DATA LOSS: Re-ordering tabs then saving renames files and overwrites without confirmation #901

Closed
Deozaan opened this issue Aug 19, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Deozaan
Copy link

Deozaan commented Aug 19, 2023

Pixelorama version:
0.11.1-stable

OS/device including version:
Windows 10

Issue description:
I had several numbered projects open. I then opened some more numbered projects as well, and then dragged the tabs around to put them into numerical order. Then I made some changes to some of the projects and saved with ctrl-s. Then I noticed my tabs were no longer in order so I re-ordered them again. After more work I noticed the tabs were mixed up again. So I decided it would be easiest to just close all my files and open them in the proper order.

When I opened them I saw that some of the filenames no longer matched the art in them, and some of the files had the same artwork as others, while some artwork was missing entirely. 😭

What I think happened: Dragging and dropping the tabs doesn't update some internal list/array of filenames. So if for example I have something called hero.pxo in the 3rd tab, and I drag it to the 5th tab so now the 3rd tab shows me monster.pxo, if I make changes to monster.pxo and press ctrl-s to save, it looks up some internally stored filename for the 3rd tab which it sees is stored as hero.pxo so the monster.pxo file gets renamed to (and overwrites) hero.pxo and if I happen to close hero.pxo before finding it and manually "saving as..." back to the original filename, I've lost the original hero.pxo artwork.

Steps to reproduce:
Described above.

@Deozaan Deozaan added the bug Something isn't working label Aug 19, 2023
@OverloadedOrama
Copy link
Member

Thanks for reporting, and sorry for the data loss. I managed to replicate this issue. I will take a look within the next few days when I have more time and release v0.11.2 that will include the fix for this bug.

@OverloadedOrama
Copy link
Member

I think I have fixed the issue now in the latest commit. If you want, feel free to download a nightly version to confirm whether it still happens or not. If it does I will re-open the issue. Thanks again for the report!

https://nightly.link/Orama-Interactive/Pixelorama/workflows/dev-desktop-builds/master

@Deozaan
Copy link
Author

Deozaan commented Aug 20, 2023

I can no longer reproduce the error on the nightly version. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants