Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging layer with opacity < 100% causes crash #541

Closed
mrtripie opened this issue Sep 22, 2021 · 5 comments
Closed

Merging layer with opacity < 100% causes crash #541

mrtripie opened this issue Sep 22, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@mrtripie
Copy link
Contributor

Pixelorama version:

0.9

OS/device including version:

Widows 10
Gtx 1060 6GB

Issue description:

If you merge a layer that has a cel with < 100% opacity with the layer below, Pixelorama will crash.

Steps to reproduce:
1: make a file
2: add a layer
3: adjust opacity to less than 100%
4: merge with layer below.

@mrtripie mrtripie added the bug Something isn't working label Sep 22, 2021
@Variable-ind
Copy link
Contributor

I quick tested the web version, i can't seem to reproduce the bug (does it happen on web as well?)

@mrtripie
Copy link
Contributor Author

Doesn't crash in web editor, however, if I draw in the semi transparent layer there, and merge it, it won't take the opacity into account when merging.

@Variable-ind
Copy link
Contributor

Nevermind i found the bug..., There needs to be selected_layer.lock() added at line 529 of AnimationTimeline.gd

@mrtripie
Copy link
Contributor Author

That sounds likely to be what would fix the crash, will it also merge with the correct level of opacity?

Here's what I mean in the web editor, the blue square is merged in with 100% opacity when I wanted it to be merged in semi transparently:

2021-09-22.14-47-30.mp4

@Variable-ind
Copy link
Contributor

yeah, selected_layer.lock() fixes the crash along with transparency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants