Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when reloading more than one backuped empty project #445

Closed
kleonc opened this issue Jan 29, 2021 · 1 comment
Closed

Crash when reloading more than one backuped empty project #445

kleonc opened this issue Jan 29, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kleonc
Copy link
Contributor

kleonc commented Jan 29, 2021

Pixelorama version: 4001a32f2b2badc3cd31cd49e09ebbf4d8378473

Issue description: Title.
Seems like OpenSave's member arrays: current_save_paths and backup_save_paths are assumed to be the same size as arguments passed to the OpenSave.reload_backup_file method which seems to not always be the case.
Godot_v3 2 3-stable_win64_7pmZsbo1A5

Steps to reproduce:

  1. Create at least 2 empty projects (with nothing being drawn) and wait for each of them be autosaved.
  2. Terminate the program (for example by clicking stop button in the Godot). Closing Pixelorama with the X button seems to not cause the crash.
  3. Run Pixelorama again and confirm reloading backups.
@kleonc kleonc added the bug Something isn't working label Jan 29, 2021
@OverloadedOrama
Copy link
Member

OverloadedOrama commented Jan 30, 2021

Seems like the issue happens because importing a new project when the current one is empty, replaces the empty project instead of creating a new tab. This behavior happens when importing backups too, the first project is empty, so the second one replaces it, thus a new value is not being appended in backup_save_paths[], which results in the error. It should get fixed in the next commit, so empty backups will not get replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants