Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key combinations don't repeat when held #401

Closed
Riteo opened this issue Dec 15, 2020 · 5 comments · Fixed by #405
Closed

Key combinations don't repeat when held #401

Riteo opened this issue Dec 15, 2020 · 5 comments · Fixed by #405
Labels
bug Something isn't working

Comments

@Riteo
Copy link

Riteo commented Dec 15, 2020

Pixelorama version:
v0.8.2-stable

OS/device including version:
Arch Linux 5.9.11.arch2 i3/Nvidia 1060 3GB drivers version 455.45.01

Issue description:
While holding ctrl+z, ctrl+y or any other key combination, their respective action gets executed only once.
It get's tiring really fast to keep pressing the same combination over and over again.

Steps to reproduce:
Draw a bunch of lines, then hold ctrl+z. Notice how only the last action gets reverted, and nothing more.

If this isn't intended behaviour, I can send a PR myself.

@Riteo Riteo added the bug Something isn't working label Dec 15, 2020
@Schweini07
Copy link
Contributor

I wouldn't Label this as a bug, rather a enhancement. The feature you are describing is just not implemented.
If you have nothing against it @OverloadedOrama I'd like to try to tackle this myself.

@OverloadedOrama
Copy link
Member

I wouldn't Label this as a bug, rather a enhancement. The feature you are describing is just not implemented.
If you have nothing against it @OverloadedOrama I'd like to try to tackle this myself.

@Schweini07 Sure, go for it!

@Schweini07
Copy link
Contributor

Schweini07 commented Dec 16, 2020

I got it to work.
2020-12-16 13-11-29
It's a pretty interesting implementation and I quite like it.
I just have to wait until my move tool PR is closed to open this PR, as I am not using an extra branch for the move tool, but master, because of "complications".
See you in hell Git.

@Riteo
Copy link
Author

Riteo commented Dec 16, 2020

@Schweini07 one small thing: IMO those action notifications should be spaced a bit, but I guess that might be a separate issue.

@Schweini07
Copy link
Contributor

Schweini07 commented Dec 16, 2020

I thought about that, but yes I think this should be something seperate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants